[Bugfix] fix java.lang.IllegalArgumentException: Self-suppression not permitted #5262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… permitted Issues open-telemetry#5239 Signed-off-by: dujiaxu <dujiaxu@xiaomi.com>
|
|
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #5262 +/- ##
============================================
- Coverage 91.07% 90.95% -0.13%
- Complexity 4881 4905 +24
============================================
Files 549 552 +3
Lines 14428 14490 +62
Branches 1374 1372 -2
============================================
+ Hits 13141 13179 +38
- Misses 892 912 +20
- Partials 395 399 +4
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
jack-berg
reviewed
Mar 2, 2023
exporters/common/src/main/java/io/opentelemetry/exporter/internal/marshal/ProtoSerializer.java
Show resolved
Hide resolved
jack-berg
approved these changes
Mar 9, 2023
|
Hmm... it looks like this commit is missing the user id required to validate CLA. Can you try to follow these instructions and then force push fresh commits? If you can do this and the CLA is signed before tomorrow at about this time, I'll merge this PR to include it in this month's release. |
|
Closing in favor of #5318. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix java.lang.IllegalArgumentException: Self-suppression not permitted
Issues #5239