Fix marshaler self suppression error #5318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #5318 +/- ##
=========================================
Coverage 90.99% 90.99%
Complexity 4901 4901
=========================================
Files 551 551
Lines 14484 14487 +3
Branches 1369 1369
=========================================
+ Hits 13179 13182 +3
Misses 907 907
Partials 398 398
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
jkwatson
reviewed
Mar 23, 2023
exporters/common/src/main/java/io/opentelemetry/exporter/internal/marshal/ProtoSerializer.java
Show resolved
Hide resolved
jkwatson
reviewed
Mar 23, 2023
exporters/common/src/test/java/io/opentelemetry/exporter/internal/marshal/MarshalerTest.java
Outdated
Show resolved
Hide resolved
mateuszrzeszutek
approved these changes
Mar 23, 2023
Comment on lines
+194
to
+197
| // If close is called automatically as part of try-with-resources, it's possible that | ||
| // output.flush() will throw the same exception. Re-throwing the same exception in a finally | ||
| // block triggers an IllegalArgumentException indicating illegal self suppression. To avoid | ||
| // this, we wrap the exception so a different instance is thrown. |
jkwatson
approved these changes
Mar 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #5239.