Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Advice proper immutable class #5532

Merged
merged 1 commit into from
Jun 14, 2023

Conversation

bogdandrutu
Copy link
Member

There may be other places like this, @open-telemetry/java-maintainers you can fix them if you want.

@bogdandrutu bogdandrutu requested a review from a team June 13, 2023 16:33
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
@codecov
Copy link

codecov bot commented Jun 13, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.01 🎉

Comparison is base (ac0b4e4) 91.34% compared to head (be325b2) 91.36%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #5532      +/-   ##
============================================
+ Coverage     91.34%   91.36%   +0.01%     
- Complexity     4957     4959       +2     
============================================
  Files           550      550              
  Lines         14543    14546       +3     
  Branches       1359     1359              
============================================
+ Hits          13285    13290       +5     
+ Misses          872      871       -1     
+ Partials        386      385       -1     
Impacted Files Coverage Δ
...emetry/sdk/metrics/internal/descriptor/Advice.java 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jack-berg jack-berg merged commit cf3b0ef into open-telemetry:main Jun 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants