Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OtlpHttp{Signal}Exporter#toBuilder() methods #5652

Merged
merged 1 commit into from
Aug 3, 2023

Conversation

jack-berg
Copy link
Member

Related to #5642. If merged, I'll follow up with a PR to add the same to the OtlpGrpc{Signal}Exporters.

@jack-berg jack-berg requested a review from a team July 24, 2023 23:30
@codecov
Copy link

codecov bot commented Jul 24, 2023

Codecov Report

Patch coverage: 95.23% and project coverage change: -0.01% ⚠️

Comparison is base (fab7d13) 91.32% compared to head (cd4a55f) 91.31%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #5652      +/-   ##
============================================
- Coverage     91.32%   91.31%   -0.01%     
- Complexity     4980     4986       +6     
============================================
  Files           554      554              
  Lines         14731    14761      +30     
  Branches       1376     1378       +2     
============================================
+ Hits          13453    13479      +26     
  Misses          884      884              
- Partials        394      398       +4     
Files Changed Coverage Δ
...o/opentelemetry/sdk/common/export/RetryPolicy.java 100.00% <ø> (ø)
...ry/exporter/internal/http/HttpExporterBuilder.java 92.10% <85.71%> (-1.55%) ⬇️
...entelemetry/exporter/internal/TlsConfigHelper.java 88.88% <100.00%> (+1.79%) ⬆️
...rter/otlp/http/logs/OtlpHttpLogRecordExporter.java 81.81% <100.00%> (+4.04%) ⬆️
...lp/http/logs/OtlpHttpLogRecordExporterBuilder.java 91.42% <100.00%> (+0.51%) ⬆️
...rter/otlp/http/metrics/OtlpHttpMetricExporter.java 86.66% <100.00%> (+2.05%) ⬆️
...lp/http/metrics/OtlpHttpMetricExporterBuilder.java 95.74% <100.00%> (+0.18%) ⬆️
...exporter/otlp/http/trace/OtlpHttpSpanExporter.java 81.81% <100.00%> (+4.04%) ⬆️
...r/otlp/http/trace/OtlpHttpSpanExporterBuilder.java 91.42% <100.00%> (+0.51%) ⬆️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jack-berg
Copy link
Member Author

@jkwatson WDYT? Would like to get the equivalent done for the grpc exporters before next release.

@jkwatson
Copy link
Contributor

jkwatson commented Aug 3, 2023

@jkwatson WDYT? Would like to get the equivalent done for the grpc exporters before next release.

no objection from me. These new public methods seem entirely reasonable.

@jack-berg jack-berg merged commit d03b485 into open-telemetry:main Aug 3, 2023
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants