Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OtlpGrpc{Signal}Exporter#toBuilder() methods #5680

Merged

Conversation

jack-berg
Copy link
Member

Continuation of #5652.

Resolves #5642.

@jack-berg jack-berg requested a review from a team August 3, 2023 21:19
@codecov
Copy link

codecov bot commented Aug 3, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (a9b285d) 91.32% compared to head (6ea11c1) 91.32%.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #5680   +/-   ##
=========================================
  Coverage     91.32%   91.32%           
- Complexity     4988     4995    +7     
=========================================
  Files           554      554           
  Lines         14765    14789   +24     
  Branches       1378     1379    +1     
=========================================
+ Hits          13484    13506   +22     
- Misses          883      884    +1     
- Partials        398      399    +1     
Files Changed Coverage Δ
...ry/exporter/internal/grpc/GrpcExporterBuilder.java 98.88% <100.00%> (+0.17%) ⬆️
.../exporter/otlp/logs/OtlpGrpcLogRecordExporter.java 81.81% <100.00%> (+4.04%) ⬆️
...er/otlp/logs/OtlpGrpcLogRecordExporterBuilder.java 92.68% <100.00%> (+0.37%) ⬆️
.../exporter/otlp/metrics/OtlpGrpcMetricExporter.java 86.66% <100.00%> (+2.05%) ⬆️
...er/otlp/metrics/OtlpGrpcMetricExporterBuilder.java 100.00% <100.00%> (ø)
...etry/exporter/otlp/trace/OtlpGrpcSpanExporter.java 81.81% <100.00%> (+4.04%) ⬆️
...porter/otlp/trace/OtlpGrpcSpanExporterBuilder.java 92.68% <100.00%> (+0.37%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jack-berg jack-berg merged commit 50a81fa into open-telemetry:main Aug 7, 2023
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add OTLP exporter #toBuilder() methods to ease autoconfigure customization
3 participants