Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for tedious v18 #2266

Closed
kirrg001 opened this issue Jun 7, 2024 · 0 comments · Fixed by #2381 or #2375
Closed

Add support for tedious v18 #2266

kirrg001 opened this issue Jun 7, 2024 · 0 comments · Fixed by #2381 or #2375
Labels
instrumentation-request

Comments

@kirrg001
Copy link
Contributor

kirrg001 commented Jun 7, 2024

Hi there!

We have recently added support for v16 and v17.
Tedious released v18 four month ago.

I will try to create pull request.

Cheers
@kirrg001 kirrg001 mentioned this issue Jun 7, 2024
Closed
kirrg001 added a commit to instana/opentelemetry-js-contrib that referenced this issue Jun 7, 2024
@kirrg001
feat(instr-tedious): added support for v18
e5b46bf 
closes open-telemetry#2266
kirrg001 added a commit to instana/opentelemetry-js-contrib that referenced this issue Jun 7, 2024
@kirrg001
feat(instr-tedious): added support for v18
c9007d9 
closes open-telemetry#2266
kirrg001 added a commit to instana/opentelemetry-js-contrib that referenced this issue Jun 7, 2024
@kirrg001
feat(instr-tedious): added support for v18
9dea514 
closes open-telemetry#2266
@kirrg001 kirrg001 mentioned this issue Jun 7, 2024
Closed
kirrg001 added a commit to instana/opentelemetry-js-contrib that referenced this issue Jun 7, 2024
@kirrg001
feat(instr-tedious): added support for v18
f11a85e 
closes open-telemetry#2266
kirrg001 added a commit to instana/opentelemetry-js-contrib that referenced this issue Jun 7, 2024
@kirrg001
feat(instr-tedious): added support for v18
7bfe30a 
closes open-telemetry#2266
kirrg001 added a commit to instana/opentelemetry-js-contrib that referenced this issue Jun 7, 2024
@kirrg001
feat(instr-tedious): added support for v18
5a068af 
closes open-telemetry#2266
kirrg001 added a commit to instana/opentelemetry-js-contrib that referenced this issue Jun 10, 2024
@kirrg001
feat(instr-tedious): added support for v18
1696fa7 
closes open-telemetry#2266
kirrg001 added a commit to instana/opentelemetry-js-contrib that referenced this issue Jun 10, 2024
@kirrg001
feat(instr-tedious): added support for v18
ed80e2d 
closes open-telemetry#2266
kirrg001 added a commit to instana/opentelemetry-js-contrib that referenced this issue Jun 12, 2024
@kirrg001
feat(instr-tedious): added support for v18
8df5740 
closes open-telemetry#2266
@trentm trentm mentioned this issue Jun 27, 2024
Closed
trentm added a commit to trentm/opentelemetry-js-contrib that referenced this issue Aug 10, 2024
@trentm
feat(instr-tedious): support tedious@18
16f4442 
tedious@18 adds its own .d.ts files. Compiling with them requires
TypeScript v5, and either target:'es2022' for 'AggregateError'
or using skipLibCheck:true in tsconfig.json.

This change limits the update to TypeScript v5 to just while
testing tedious@18 via test-all-versions' support for
'peerDependencies'.

THis also drops ts-mocha in favour of 'mocha --require ts-node/register'
as was done on opentelemetry-js.git in open-telemetry/opentelemetry-js#4840

Closes: open-telemetry#2266
@trentm trentm mentioned this issue Aug 14, 2024
Merged
@trentm trentm closed this as completed in 0e9791a Aug 19, 2024
@dyladan dyladan mentioned this issue Aug 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
instrumentation-request
Projects
None yet
Milestone
No milestone
1 participant
@kirrg001