feat(instrumentation-tedious): support tedious@18 #2381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tedious@18 adds its own .d.ts files. Compiling with them requires TypeScript v5, and either target:'es2022' for 'AggregateError' or using skipLibCheck:true in tsconfig.json. This change limits the update to TypeScript v5 to just while testing tedious@18 via test-all-versions' support for 'peerDependencies'. THis also drops ts-mocha in favour of 'mocha --require ts-node/register' as was done on opentelemetry-js.git in open-telemetry/opentelemetry-js#4840 Closes: open-telemetry#2266
github-actions
bot
added
pkg:instrumentation-tedious
pkg-status:unmaintained
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2381 +/- ##
==========================================
- Coverage 90.97% 90.56% -0.42%
==========================================
Files 146 157 +11
Lines 7492 7631 +139
Branches 1502 1574 +72
==========================================
+ Hits 6816 6911 +95
- Misses 676 720 +44
|
|
For the record: some earlier skipLibCheck discussion here: #2165 |
|
This package does not have an assigned component owner and is considered unmaintained. As such this package is in feature-freeze and this PR will be closed with 14 days unless a new owner or a sponsor (a member of @open-telemetry/javascript-approvers) for the feature is found. It is the responsibility of the author to find a sponsor for this feature. |
trentm
added
the
has:sponsor
david-luna
approved these changes
Aug 19, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This builds on work by @kirrg001 in #2267.
tedious@18 added its own types, dropping the need to use
@types/tedious. However, it requires TypeScript v5 to use with TS,
which was challenging.
install TS 5 when testing tedious@18.
as is being used in the core repo.
the tests when using tedious@18. It was that or bump to
target:es2022, which could impact the published code. JS SIG
discussion decided using skipLibCheck is probably fine.
More discussion here: #2267 (comment)
Obsoletes: #2267
Closes: #2266