-
Notifications
You must be signed in to change notification settings - Fork 529
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: remove skipLibCheck: true from tsconfigs where it is not necessary #2165
chore: remove skipLibCheck: true from tsconfigs where it is not necessary #2165
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2165 +/- ##
==========================================
- Coverage 90.97% 90.46% -0.52%
==========================================
Files 146 147 +1
Lines 7492 7580 +88
Branches 1502 1574 +72
==========================================
+ Hits 6816 6857 +41
- Misses 676 723 +47 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
even though they're not necessary anymore...
LGTM but could I get more context on this? Thanks!
We've seen this cause some confusion over at #1985. It looks like some instrumentations had set |
curious why this instrumentation still need the setting |
There's some problem with the |
skipLibCheck: true
is set a few instrumentation libraries, even though they're not necessary anymore. The only remaining instrumentation that needs it is@opentelemetry/instrumentation-lru-memoizer
.