-
Notifications
You must be signed in to change notification settings - Fork 506
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): update dependency semver to v7.5.4 #1646
Conversation
chore(deps): update dependency semver to v7.5.4
Thank you @AasthaMehtaTech for the contribution. I support aligning the Would you mind aligning these dependencies too? I assume the same security alert will show up there as well. I think our conventions are to pin dev dependencies since they are not part of the distribution and can introduce breaking changes for our builds and CI. For @haddasbronfman documented the reasoning here for the core repo as a reference. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1646 +/- ##
=======================================
Coverage 91.77% 91.77%
=======================================
Files 139 139
Lines 7112 7112
Branches 1427 1427
=======================================
Hits 6527 6527
Misses 585 585 |
plugins/node/opentelemetry-instrumentation-generic-pool/package.json
Outdated
Show resolved
Hide resolved
plugins/node/opentelemetry-instrumentation-nestjs-core/package.json
Outdated
Show resolved
Hide resolved
plugins/node/opentelemetry-instrumentation-restify/package.json
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the fix 🥇
Which problem is this PR solving?
Short description of the changes