Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(instrumentation-dns): use caret range for semver regular dependency #1654

Merged
merged 1 commit into from
Aug 29, 2023

Conversation

blumamir
Copy link
Member

#1646 fixed the version of "semver" in the repo, but I accidentally merged it without noticing that it pinned a regular dependency (not dev) to a specific version which does not follow our conventions as documented here.

This PR is to fix this. After it is merged, the "semver" versions in the repo should be aligned correctly

@blumamir blumamir requested a review from a team August 29, 2023 06:08
@codecov
Copy link

codecov bot commented Aug 29, 2023

Codecov Report

Merging #1654 (ba9277c) into main (a556179) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1654   +/-   ##
=======================================
  Coverage   91.77%   91.77%           
=======================================
  Files         139      139           
  Lines        7112     7112           
  Branches     1427     1427           
=======================================
  Hits         6527     6527           
  Misses        585      585           

Copy link
Member

@pichlermarc pichlermarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🙂

@blumamir blumamir merged commit d9cd8d7 into open-telemetry:main Aug 29, 2023
15 checks passed
@dyladan dyladan mentioned this pull request Aug 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants