-
Notifications
You must be signed in to change notification settings - Fork 821
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(prometheus): update prometheus exporter with wip metrics sdk #2824
feat(prometheus): update prometheus exporter with wip metrics sdk #2824
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2824 +/- ##
==========================================
+ Coverage 93.06% 93.46% +0.40%
==========================================
Files 150 162 +12
Lines 4713 5568 +855
Branches 994 1178 +184
==========================================
+ Hits 4386 5204 +818
- Misses 327 364 +37
|
b7f763d
to
675f7e2
Compare
675f7e2
to
fbea6b9
Compare
experimental/packages/opentelemetry-exporter-prometheus/src/PrometheusSerializer.ts
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't see anything in the code, but do you do anything with unit? In the python exporter, we use the official prometheus client library to generate text format and it actually accepts the unit and concatenates it into the metric name. Example test case.
I know there is a current spec effort to document OTLP<->Prometheus conversion, but it doesn't say anything about unit right now. Thoughts?
Update: found this in the prometheus docs. I will check with my coworker who's working on the OTLP to prom spec to see if this should be officially added.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM it's really a lot less change than I thought would be needed.
@@ -1,6 +1,7 @@ | |||
{ | |||
"name": "@opentelemetry/exporter-prometheus", | |||
"name": "@opentelemetry/exporter-prometheus-wip", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After the OTLP exporters are updated we should remove wip from all names and have a release
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need to change the name here I think. The package is private and nothing depends on it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reverted :)
@@ -1,6 +1,7 @@ | |||
{ | |||
"name": "@opentelemetry/exporter-prometheus", | |||
"name": "@opentelemetry/exporter-prometheus-wip", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need to change the name here I think. The package is private and nothing depends on it.
Which problem is this PR solving?
Fixes Partially #2773
This PR updates the Prometheus Exporter to the latest Metrics SDK type definitions.
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Checklist: