Bump kubernetes to 1.27 operator and target allocator #1653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think we are blocked on this kubernetes-sigs/controller-runtime#2189 unfortunately, seems dependencies are failing because of incompatibilities between these libs. |
|
and now we wait on kubernetes-sigs/controller-runtime#2297 |
yuriolisa
approved these changes
May 17, 2023
|
It seems that the CI failed and the PR needs to be rebased. |
|
Another unexpected update that broke us kubernetes-sigs/controller-runtime#2134... we also may need to wait on this kubebuilder PR before we can merge this. |
pavolloffay
reviewed
May 24, 2023
|
LGTM just the imports need to be sorted |
|
ha yeah noticed that as soon as i pushed |
|
note: i will need to separately update the kubernetes versions for opamp-bridge, i tried to get go workspaces working, but it wasn't happy w/ me. |
pavolloffay
approved these changes
May 25, 2023
| @@ -177,21 +178,21 @@ func (r *Instrumentation) Default() { | |||
| var _ webhook.Validator = &Instrumentation{} | |||
|
|
|||
| // ValidateCreate implements webhook.Validator so a webhook will be registered for the type. | |||
| func (r *Instrumentation) ValidateCreate() error { | |||
| func (r *Instrumentation) ValidateCreate() (admission.Warnings, error) { | |||
There was a problem hiding this comment.
this is cool, we can start using the warnings
|
Created #1769 to handle the build jobs |
jaronoff97
changed the title
ItielOlenick
pushed a commit
to ItielOlenick/opentelemetry-operator
that referenced
this pull request
May 1, 2024
…#1653) * Bump kubernetes to 1.27 everywhere * fix broken updates * Fix dep order * rename * upgrade controller-gen and kustomize * bump allocator deps * unbump opamp bridge for now * upgrade deprecations * fix kuttl test * bundle
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1652
This upgrades all kubernetes dependencies in each module to the latest version 0.27.0 for Kubernetes 1.27.0
Some extra upgrades were included, the dependencies of which have been reviewed and should all be safe upgrades.