chore: do not log error when receiver has no endpoint #1666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some receivers don't have an `endpoint` config value. No need to log a type error for these.
matej-g
approved these changes
Apr 19, 2023
Great idea. See follow-on commit. |
TylerHelmuth
approved these changes
Apr 19, 2023
| switch endpoint := endpoint.(type) { | ||
| switch e := endpoint.(type) { | ||
| case nil: | ||
| break |
There was a problem hiding this comment.
We can omit this break, but I understand if it was added for readability.
There was a problem hiding this comment.
Right. There are a few ways to make this functional change, but this seemed the most readable.
6 tasks
jaronoff97
approved these changes
Apr 20, 2023
ItielOlenick
pushed a commit
to ItielOlenick/opentelemetry-operator
that referenced
this pull request
May 1, 2024
…#1666) * chore: do not log error when receiver has no endpoint Some receivers don't have an `endpoint` config value. No need to log a type error for these. * chore: integrate review feedback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some receivers don't have an
endpointconfig value. No need to log a type error for these.FWIW, setting
endpoint: :1quiets the log, but causes the Kafka receiver to fail to unmarshal its config.