Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: do not log error when receiver has no endpoint #1666

Merged
merged 2 commits into from
Apr 24, 2023
Merged

chore: do not log error when receiver has no endpoint #1666

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
73944f2
chore: do not log error when receiver has no endpoint
jacobmarble Apr 18, 2023
793f5f5
chore: integrate review feedback
jacobmarble Apr 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions pkg/collector/parser/receiver.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,6 +116,8 @@ func singlePortFromConfigEndpoint(logger logr.Logger, name string, config map[in
}

switch endpoint := endpoint.(type) {
case nil:
break
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can omit this break, but I understand if it was added for readability.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right. There are a few ways to make this functional change, but this seemed the most readable.

case string:
port, err := portFromEndpoint(endpoint)
if err != nil {
Expand Down