Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support newer API namespace for open-telemetry/api >= 1.0.0beta10 #171

Merged
merged 2 commits into from
Jun 26, 2023

Conversation

siketyan
Copy link
Contributor

Closes open-telemetry/opentelemetry-php#1056

This pull request resolves undefined class references caused by 1.0.0beta10 release including moving classes in OpenTelemetry\API\Common to OpenTelemetry\API.

siketyan added 2 commits June 26, 2023 22:06
Signed-off-by: Natsuki Ikeguchi <n_ikeguchi@yumemi.co.jp>
Signed-off-by: Natsuki Ikeguchi <n_ikeguchi@yumemi.co.jp>
@siketyan siketyan requested a review from a team June 26, 2023 13:26
@codecov
Copy link

codecov bot commented Jun 26, 2023

Codecov Report

Merging #171 (52c9b4a) into main (ce970de) will decrease coverage by 32.79%.
The diff coverage is 0.00%.

❗ Current head 52c9b4a differs from pull request most recent head fed9693. Consider uploading reports for the commit fed9693 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #171       +/-   ##
============================================
- Coverage     40.76%   7.98%   -32.79%     
+ Complexity      313     239       -74     
============================================
  Files            28      24        -4     
  Lines           969     952       -17     
============================================
- Hits            395      76      -319     
- Misses          574     876      +302     
Flag Coverage Δ
7.4 17.64% <ø> (-39.52%) ⬇️
8.0 9.93% <0.00%> (-30.77%) ⬇️
8.1 10.06% <0.00%> (-30.74%) ⬇️
8.2 7.99% <0.00%> (-32.82%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...AsyncClient/src/HttpAsyncClientInstrumentation.php 0.00% <0.00%> (ø)
src/Instrumentation/IO/src/IOInstrumentation.php 0.00% <ø> (ø)
src/Instrumentation/PDO/src/PDOInstrumentation.php 0.00% <ø> (ø)
...Instrumentation/Psr15/src/Psr15Instrumentation.php 0.00% <ø> (ø)
...Instrumentation/Psr18/src/Psr18Instrumentation.php 0.00% <0.00%> (ø)
...c/Instrumentation/Slim/src/SlimInstrumentation.php 0.00% <ø> (ø)
...entation/Symfony/src/HttpClientInstrumentation.php 0.00% <ø> (ø)
...rumentation/Symfony/src/SymfonyInstrumentation.php 0.00% <ø> (ø)

... and 12 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce970de...fed9693. Read the comment docs.

@siketyan
Copy link
Contributor Author

Oh, just superseded by #172 ?

@siketyan siketyan mentioned this pull request Jun 26, 2023
@brettmc brettmc merged commit e866749 into open-telemetry:main Jun 26, 2023
brettmc added a commit to brettmc/opentelemetry-php-contrib that referenced this pull request Jun 26, 2023
cleaning up the last couple of breaks not included in open-telemetry#171
@brettmc
Copy link
Collaborator

brettmc commented Jun 26, 2023

Thankyou for finding and fixing this so quickly, @siketyan
I've released new versions of the packages that you fixed.

@siketyan siketyan deleted the feat/support-newer-api branch June 27, 2023 03:00
brettmc added a commit that referenced this pull request Jul 3, 2023
cleaning up the last couple of breaks not included in #171
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[opentelemetry-php-contrib] Support newer API namespace for open-telemetry/api >= 1.0.0beta10
2 participants