-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Support newer API namespace for open-telemetry/api >= 1.0.0beta10 #171
feat: Support newer API namespace for open-telemetry/api >= 1.0.0beta10 #171
Conversation
Signed-off-by: Natsuki Ikeguchi <n_ikeguchi@yumemi.co.jp>
Signed-off-by: Natsuki Ikeguchi <n_ikeguchi@yumemi.co.jp>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #171 +/- ##
============================================
- Coverage 40.76% 7.98% -32.79%
+ Complexity 313 239 -74
============================================
Files 28 24 -4
Lines 969 952 -17
============================================
- Hits 395 76 -319
- Misses 574 876 +302
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 12 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Oh, just superseded by #172 ? |
cleaning up the last couple of breaks not included in open-telemetry#171
Thankyou for finding and fixing this so quickly, @siketyan |
cleaning up the last couple of breaks not included in #171
Closes open-telemetry/opentelemetry-php#1056
This pull request resolves undefined class references caused by 1.0.0beta10 release including moving classes in OpenTelemetry\API\Common to OpenTelemetry\API.