Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing api breakages #172

Closed
wants to merge 1 commit into from

Conversation

brettmc
Copy link
Collaborator

@brettmc brettmc commented Jun 26, 2023

the SDK BC layer only works if the SDK is installed :(

the SDK BC layer only works if the SDK is installed :(
@codecov
Copy link

codecov bot commented Jun 26, 2023

Codecov Report

Merging #172 (abdea1b) into main (ce970de) will decrease coverage by 16.18%.
The diff coverage is 25.00%.

❗ Current head abdea1b differs from pull request most recent head 041f049. Consider uploading reports for the commit 041f049 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##               main     #172       +/-   ##
=============================================
- Coverage     40.76%   24.59%   -16.18%     
- Complexity      313      409       +96     
=============================================
  Files            28       40       +12     
  Lines           969     1533      +564     
=============================================
- Hits            395      377       -18     
- Misses          574     1156      +582     
Flag Coverage Δ
7.4 55.92% <100.00%> (-1.24%) ⬇️
8.0 28.14% <25.00%> (-12.56%) ⬇️
8.1 28.21% <25.00%> (-12.59%) ⬇️
8.2 24.60% <25.00%> (-16.20%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/Aws/src/AwsSdkInstrumentation.php 49.01% <ø> (ø)
...AsyncClient/src/HttpAsyncClientInstrumentation.php 0.00% <0.00%> (ø)
src/Instrumentation/Laravel/src/QueryWatcher.php 0.00% <ø> (ø)
src/Instrumentation/PDO/src/PDOInstrumentation.php 0.00% <ø> (ø)
...Instrumentation/Psr15/src/Psr15Instrumentation.php 0.00% <ø> (ø)
...Instrumentation/Psr18/src/Psr18Instrumentation.php 0.00% <0.00%> (ø)
...c/Instrumentation/Slim/src/SlimInstrumentation.php 0.00% <ø> (ø)
src/Aws/src/Xray/Propagator.php 100.00% <100.00%> (ø)

... and 12 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce970de...041f049. Read the comment docs.

@siketyan
Copy link
Contributor

siketyan commented Jun 26, 2023

Hello @brettmc san, thank you for this PR to fix the API breakages! Fortunately I just dropped another PR #171 for fixing the same problem 😂 Please feel free to merge #171 to here or just close my PR and supersede by this. Thank you!

@brettmc
Copy link
Collaborator Author

brettmc commented Jun 26, 2023

Thankyou, @siketyan
I'll use your PR :)

@brettmc brettmc closed this Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants