Update to v2 to reduce deps #154
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pellared
changed the title
pellared
commented
Feb 22, 2024
There was a problem hiding this comment.
Depends on open-telemetry/opentelemetry-proto#532
But the SED_EXPR could be updated instead.
This was referenced Feb 22, 2024
|
Closing per #100 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #100
Thanks to it consumers that do not use gRPC (but send protobuf over HTTP) can import
go.opentelemetry.io/proto/otlp/v2that does not depend ongoogle.golang.org/grpc.The existing v1
go.opentelemetry.io/proto/otlppackages (and module) would have to be deprecated afterwards and give instruction which packages should be used instead.Alternative approach: #155