Add slim Go module without gRPC dependencies #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pellared
changed the title
This was referenced Feb 22, 2024
This comment was marked as outdated.
This comment was marked as outdated.
pellared
changed the title
pellared
changed the title
|
PTAL @open-telemetry/go-approvers |
MrAlias
approved these changes
Feb 29, 2024
|
Would |
I like the name as it shows that it has also has "less things" (offers a smaller amount of types, functionality, dependencies). I will update the PR. |
pellared
changed the title
|
This codebase is not used by OTel Collector. Collector is generating the code from proto files on its own in https://github.com/open-telemetry/opentelemetry-collector/blob/main/Makefile. |
MrAlias
approved these changes
Feb 29, 2024
|
@open-telemetry/go-approvers PTAL. I also tested the changes done in this PR here: open-telemetry/opentelemetry-go#5031 |
MadVikingGod
approved these changes
Mar 8, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #100
Towards open-telemetry/opentelemetry-go#2579
Add
go.opentelemetry.io/proto/slim/otlpGo module that does not generate gRPC code.Thanks to it codebase which only sends protobuf over HTTP can import
go.opentelemetry.io/proto/slim/otlpthat will not depend ongoogle.golang.org/grpc.The plan is to publish a
v1.2.0-rc.1release once this PR is merged. We prefer to releasev1.2.0whenv1.2.0of https://github.com/open-telemetry/opentelemetry-proto is released (to have version parity).Tested with open-telemetry/opentelemetry-go#5031