Add connection attributes to sqlalchemy connect span #1608
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
srikanthccv
approved these changes
Jan 30, 2023
bschoenmaeckers
force-pushed
the
sqlalchemy-connect
branch
from
5fefc0d to
05bd866
Compare
|
Please fix the changelog conflict |
auto-merge was automatically disabled
February 13, 2023 21:39
Head branch was pushed to by a user without write access
bschoenmaeckers
force-pushed
the
sqlalchemy-connect
branch
from
e98d2b3 to
cb52774
Compare
|
Conflict fixed |
shalevr
approved these changes
Feb 13, 2023
bschoenmaeckers
force-pushed
the
sqlalchemy-connect
branch
from
e5271de to
1c6a24c
Compare
srikanthccv
reviewed
Feb 18, 2023
CHANGELOG.md
Outdated
| @@ -29,6 +29,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 | |||
| ([#1592](https://github.com/open-telemetry/opentelemetry-python-contrib/pull/1592)) | |||
| - `opentelemetry-instrumentation-django` Allow explicit `excluded_urls` configuration through `instrument()` | |||
| ([#1618](https://github.com/open-telemetry/opentelemetry-python-contrib/pull/1618)) | |||
| - Add connection attributes to sqlalchemy connect span | |||
| ([#1608](https://github.com/open-telemetry/opentelemetry-python-contrib/pull/1608)) | |||
There was a problem hiding this comment.
Move this to ## Unreleased ###Added section
|
Fixed formatting. Please run checks again. |
shalevr
added a commit
to shalevr/opentelemetry-python-contrib
that referenced
this pull request
Feb 23, 2023
…/github.com/shalevr/opentelemetry-python-contrib into Change-metrics-tests-to-work-with-test_base * 'Change-metrics-tests-to-work-with-test_base' of https://github.com/shalevr/opentelemetry-python-contrib: Fix issue with Flask instrumentation when a request spawn children threads and copies the request context (open-telemetry#1654) Add connection attributes to sqlalchemy connect span (open-telemetry#1608) Add boto3sqs to docs (open-telemetry#1666) Audit and test opentelemetry-instrumentation-elasticsearch NoOpTracer… (open-telemetry#1616) Copy change log updates from release/v1.16.x-0.37bx (open-telemetry#1683) Update version to 1.17.0.dev/0.38b0.dev (open-telemetry#1677) Fix CI Failure (open-telemetry#1680) Add better debugging if hatch subprocess fails (open-telemetry#1672) Add confluent kafka docs (open-telemetry#1668) Support aio_pika 9 (open-telemetry#1670) Audit and test opentelemetry-instrumentation-wsgi NoOpTracerProvider (open-telemetry#1610) bot (open-telemetry#1667) Add commit method for ConfluentKafkaInstrumentor's ProxiedConsumer (open-telemetry#1656) Revert open-telemetry#1097 (open-telemetry#1660) Audit and test opentelemetry-instrumentation-django NoOpTracerProvider (open-telemetry#1611) Audit and test opentelemetry-instrumentation-aiohttp-client NoOpTrace… (open-telemetry#1612) Audit and test opentelemetry-instrumentation-flask NoOpTracerProvider (open-telemetry#1614) Audit and test opentelemetry-instrumentation-dbapi NoOpTracerProvider (open-telemetry#1607)
pridhi-arora
pushed a commit
to pridhi-arora/opentelemetry-python-contrib
that referenced
this pull request
Feb 25, 2023
…1608) * Add connection attributes to sqlalchemy connect span * Fix formatting * Move changelog entry to unreleased section --------- Co-authored-by: Srikanth Chekuri <srikanth.chekuri92@gmail.com> Co-authored-by: Shalev Roda <65566801+shalevr@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The connect span did not have the same attributes as other sqlalchemy spans. This MR adds the same connection attributes as the other spans extracted out of the connection url.
Related to #1134
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
I have updated the tests accordingly.
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.