Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert #1097 #1660

Merged
merged 3 commits into from
Feb 13, 2023
Merged

Revert #1097 #1660

merged 3 commits into from
Feb 13, 2023

Conversation

ocelotl
Copy link
Contributor

@ocelotl ocelotl commented Feb 10, 2023

Several issues have arisen from this bugfix, reverting here until a better solution can be found.

Fixes #1658

@ocelotl ocelotl added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Feb 10, 2023
@ocelotl ocelotl self-assigned this Feb 10, 2023
Several issues have arisen from this bugfix, reverting here until a
better solution can be found.

Fixes open-telemetry#1658
Copy link
Member

@aabmass aabmass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be great to get manual confirmation that this fixes the issue from someone with a repro

@ocelotl
Copy link
Contributor Author

ocelotl commented Feb 13, 2023

@phillipuniverse @rogersd @philipcwhite please take a look and let us know if this allows you to work around your issues.

@phillipuniverse
Copy link
Contributor

phillipuniverse commented Feb 13, 2023

@ocelotl I have confirmed this fixes my originally reported issue with the coverage module at #1179!

@ocelotl ocelotl merged commit b8d7448 into open-telemetry:main Feb 13, 2023
@ocelotl ocelotl deleted the issue_1658 branch February 13, 2023 16:46
shalevr added a commit to shalevr/opentelemetry-python-contrib that referenced this pull request Feb 23, 2023
…/github.com/shalevr/opentelemetry-python-contrib into Change-metrics-tests-to-work-with-test_base

* 'Change-metrics-tests-to-work-with-test_base' of https://github.com/shalevr/opentelemetry-python-contrib:
  Fix issue with Flask instrumentation when a request spawn children threads and copies the request context (open-telemetry#1654)
  Add connection attributes to sqlalchemy connect span (open-telemetry#1608)
  Add boto3sqs to docs (open-telemetry#1666)
  Audit and test opentelemetry-instrumentation-elasticsearch NoOpTracer… (open-telemetry#1616)
  Copy change log updates from release/v1.16.x-0.37bx (open-telemetry#1683)
  Update version to 1.17.0.dev/0.38b0.dev (open-telemetry#1677)
  Fix CI Failure (open-telemetry#1680)
  Add better debugging if hatch subprocess fails (open-telemetry#1672)
  Add confluent kafka docs (open-telemetry#1668)
  Support aio_pika 9 (open-telemetry#1670)
  Audit and test opentelemetry-instrumentation-wsgi NoOpTracerProvider (open-telemetry#1610)
  bot (open-telemetry#1667)
  Add commit method for ConfluentKafkaInstrumentor's ProxiedConsumer (open-telemetry#1656)
  Revert open-telemetry#1097 (open-telemetry#1660)
  Audit and test opentelemetry-instrumentation-django NoOpTracerProvider (open-telemetry#1611)
  Audit and test opentelemetry-instrumentation-aiohttp-client NoOpTrace… (open-telemetry#1612)
  Audit and test opentelemetry-instrumentation-flask NoOpTracerProvider (open-telemetry#1614)
  Audit and test opentelemetry-instrumentation-dbapi NoOpTracerProvider (open-telemetry#1607)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Revert fix for #1077
4 participants