Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Zipkin exporter must support Zipkin v1 JSON format #1173

Closed
codeboten opened this issue Sep 28, 2020 · 4 comments · Fixed by #1411
Closed

Zipkin exporter must support Zipkin v1 JSON format #1173

codeboten opened this issue Sep 28, 2020 · 4 comments · Fixed by #1411
Assignees
@robwknox
Labels
1.0.0rc2 release candidate 2 for tracing GA exporters help wanted release:required-for-ga To be resolved before GA release

Comments

@codeboten
Copy link
Contributor

As per spec: https://github.com/open-telemetry/opentelemetry-specification/blob/master/specification/trace/sdk_exporters/zipkin.md#considerations-for-legacy-v1-format
@robwknox robwknox mentioned this issue Nov 2, 2020
Merged
6 tasks
@robwknox
Copy link
Contributor

robwknox commented Nov 6, 2020

@codeboten i'll pick this up if you want to assign to me

@codeboten
Copy link
Contributor Author

Done, thanks!

@robwknox
Copy link
Contributor

robwknox commented Nov 7, 2020 •
edited
Loading

Changes are prepped in 1173_zipkin_exporter_v1_json_support but are dependent on #1318 being merged before a PR can be created.

@robwknox robwknox mentioned this issue Nov 16, 2020
Open
6 tasks
@robwknox
Copy link
Contributor

Staged PR to give better view of changes while awaiting merge of #1318

@robwknox robwknox mentioned this issue Nov 16, 2020
Open
@robwknox robwknox mentioned this issue Nov 23, 2020
Merged
6 tasks
@codeboten codeboten added the 1.0.0rc2 release candidate 2 for tracing GA label Nov 26, 2020
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@robwknox robwknox

Labels
1.0.0rc2 release candidate 2 for tracing GA exporters help wanted release:required-for-ga To be resolved before GA release
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Zipkin exporter add support for v1 api json format robwknox/opentelemetry-python
2 participants
@codeboten @robwknox