1173 zipkin exporter v1 json support #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…RANSPORT_FORMAT_JSON/PROTOBUF vals to not overload w/ Content-Type
…ry in pyproject.toml for black
…os.environ access for retrieving env vars
…asier addition of supported API formats
….5 + a bug fix related to max_tag_value_length in the encoders
…ce_id() and encode_span_id() and base Encoder class
…not in the Sender
…exporter_v1_json_support_refactor
…kin_exporter_v1_json_support
…kin_exporter_v1_json_support
robwknox
changed the base branch from
1175_zipkin_exporter_v2_protobuf_support
to
master
…kin_exporter_v1_json_support_fix
…kin_exporter_v1_json_support
…kin_exporter_v1_json_support_fix
…kin_exporter_v1_json_support
…kin_exporter_v1_json_support
…kin_exporter_v1_json_support_fix
…kin_exporter_v1_json_support
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds support for the Zipkin Exporter v1 API json format . Since this brings the number of supported formats to 3 (v1-json, v2-json, v2-protobuf) and with v1-thrift on the way, the PR includes notable refactoring of the exporter to introduce the concept of an Encoder.
Breaking changes
ZipkinSpanExporter()signature changes:url=>endpointto be consistent with related env varOTEL_EXPORTER_ZIPKIN_ENDPOINTand packageDEFAULT_ENDPOINTipv4=>local_node_ipv4to more clearly denote this is for the local node endpointipv6=>local_node_ipv6to more clearly denote this is for the local node endpointlocal_node_port: added. This value was being improperly parsed from theurlwhen it is supposed to represent the local node listening port. Added param so that it can be passed in along with the local node ip addresses if desired.retryremoved for now to avoid confusion since the logic is not currently implemented.Not a breaking change but
ZipkinSpanExporter(service_name)is now optional to follow spec. Default is 'unknown'.Fixes open-telemetry#1173
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Checklist: