-
Notifications
You must be signed in to change notification settings - Fork 635
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Zipkin exporter v2 api support for protobuf format #1318
Merged
lzchen
merged 23 commits into
open-telemetry:master
from
robwknox:1175_zipkin_exporter_v2_protobuf_support
Nov 23, 2020
Merged
Zipkin exporter v2 api support for protobuf format #1318
lzchen
merged 23 commits into
open-telemetry:master
from
robwknox:1175_zipkin_exporter_v2_protobuf_support
Nov 23, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robwknox
requested review from
a team,
owais and
codeboten
and removed request for
a team
November 2, 2020 06:08
owais
reviewed
Nov 2, 2020
exporter/opentelemetry-exporter-zipkin/src/opentelemetry/exporter/zipkin/__init__.py
Show resolved
Hide resolved
exporter/opentelemetry-exporter-zipkin/src/opentelemetry/exporter/zipkin/__init__.py
Outdated
Show resolved
Hide resolved
exporter/opentelemetry-exporter-zipkin/src/opentelemetry/exporter/zipkin/__init__.py
Outdated
Show resolved
Hide resolved
exporter/opentelemetry-exporter-zipkin/src/opentelemetry/exporter/zipkin/__init__.py
Outdated
Show resolved
Hide resolved
…RANSPORT_FORMAT_JSON/PROTOBUF vals to not overload w/ Content-Type
…ry in pyproject.toml for black
robwknox
changed the title
[WIP] Zipkin exporter v2 api support for protobuf format
Zipkin exporter v2 api support for protobuf format
Nov 3, 2020
…os.environ access for retrieving env vars
ocelotl
approved these changes
Nov 13, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
owais
approved these changes
Nov 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
1.0.0rc2
release candidate 2 for tracing GA
release:required-for-ga
To be resolved before GA release
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds support for the Zipkin Exporter v2 API's protobuf format.
Includes 2 auto-generated files related to the protobuf format:
exporter/opentelemetry-exporter-zipkin/src/opentelemetry/exporter/zipkin/zipkin_pb2.py
the core buffer codeexporter/opentelemetry-exporter-zipkin/src/opentelemetry/exporter/zipkin/zipkin_pb2.pyi
derived mypy stub file to aid developmentFile gen command (based on google docs):
Fixes #1175
Type of change
Please delete options that are not relevant.
Breaking change is minor - the dict
opentelemetry.exporter.zipkin.SPAN_KIND_MAP
structure has changed but I suspect this is only being internally used by the module.How Has This Been Tested?
Manual testing with local zipkin server doing comparisons between JSON & protobuf data exports to ensure they identically matched. Plus full tox run against envs:
Checklist: