Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update proto to v0.17.0 #2611

Closed
wants to merge 3 commits into from
Closed

Update proto to v0.17.0 #2611

wants to merge 3 commits into from

Conversation

ocelotl
Copy link
Contributor

@ocelotl ocelotl commented Apr 16, 2022 •
edited
Loading

Update proto, this adds min/max fields for Histogram. This is needed for #2612.

@ocelotl ocelotl self-assigned this Apr 16, 2022
@ocelotl ocelotl requested a review from a team April 16, 2022 23:25
@ocelotl ocelotl mentioned this pull request Apr 16, 2022
Closed
srikanthccv
srikanthccv reviewed Apr 17, 2022
View reviewed changes
Copy link
Member

@srikanthccv srikanthccv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like min/max got merged after 0.16.0 release https://github.com/open-telemetry/opentelemetry-proto/commits/main?

CHANGELOG.md Outdated Show resolved Hide resolved
@codeboten @srikanthccv
Update CHANGELOG.md
7b32422 
Co-authored-by: Srikanth Chekuri <srikanth.chekuri92@gmail.com>
@srikanthccv
Copy link
Member

@ocelotl Just one question before approving. I don't see the min/max changes in 0.16.0 proto release. Did the gen script run on main? Won't it be a problem open-telemetry/opentelemetry-collector#5202?

@ocelotl ocelotl marked this pull request as draft April 18, 2022 18:18
@lzchen
Copy link
Contributor

lzchen commented Apr 18, 2022

Looks like open-telemetry/opentelemetry-proto#279 did not make it into 0.16.0 release.

@ocelotl
Copy link
Contributor Author

ocelotl commented Apr 18, 2022

@ocelotl Just one question before approving. I don't see the min/max changes in 0.16.0 proto release. Did the gen script run on main? Won't it be a problem open-telemetry/opentelemetry-collector#5202?

Yes, you are right. Moving this to draft to prevent accidental merging.

@codeboten codeboten mentioned this pull request Apr 19, 2022
Merged
@codeboten codeboten changed the title Update proto to v0.16.0 Update proto to v0.17.0 Apr 19, 2022
@codeboten
Copy link
Contributor

Renamed the PR to 0.17.0 since 0.16.0 didn't include the changes needed here.

@ocelotl
Copy link
Contributor Author

ocelotl commented Apr 22, 2022

Closing until there is a proto release.

@ocelotl ocelotl closed this Apr 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srikanthccv srikanthccv srikanthccv left review comments

@codeboten codeboten codeboten approved these changes

@lzchen lzchen lzchen approved these changes

Assignees

@ocelotl ocelotl

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ocelotl @srikanthccv @lzchen @codeboten