Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add min max fields to Histogram #2612

Closed
wants to merge 2 commits into from
Closed

Add min max fields to Histogram #2612

wants to merge 2 commits into from

Conversation

ocelotl
Copy link
Contributor

@ocelotl ocelotl commented Apr 16, 2022 •
edited
Loading

Fixes #2582, review #2611 first.

@ocelotl ocelotl self-assigned this Apr 16, 2022
@ocelotl ocelotl requested a review from a team April 16, 2022 23:28
@ocelotl ocelotl mentioned this pull request Apr 16, 2022
Closed
codeboten
codeboten suggested changes Apr 18, 2022
View reviewed changes
Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good, blocking until the 0.16.0 change is merged and this PR is rebased

@ocelotl
Copy link
Contributor Author

ocelotl commented Apr 22, 2022

Closing until there is a proto release.

@ocelotl ocelotl closed this Apr 22, 2022
@srikanthccv
Copy link
Member

@ocelotl You can bring this back.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codeboten codeboten codeboten requested changes

@lzchen lzchen lzchen approved these changes

Assignees

@ocelotl ocelotl

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add min/max fields to Histogram in otlp metrics exporter
4 participants
@ocelotl @srikanthccv @codeboten @lzchen