Fixes warning filter being reset #3147
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have been looking at this PR, I think there is a way to avoid the context manager and a lock if we tighten the warning filter to use line number, will add a more detailed comment when I get back home. |
|
Wouldn't it also be an option to just leave the deprecation warning until the root cause itself is fixed? |
|
@mjvankampen Thanks for your PR! This issue has been fixed by #3164, so I'll be closing this PR now 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Warning filters were being reset, resulting in warnings suddenly popping up in unrelated spots due to instrumenting with OTel.
Fixes based on https://docs.python.org/3/library/warnings.html#temporarily-suppressing-warnings although there it is noted that this is not threadsafe. I haven't been able to make sure if this is an issue yet. @ocelotl was this the reason you used a different approach? In my opinion this non-thread safe approach makes more sense than just throwing away all filters.
Fixes #3102
Type of change
How Has This Been Tested?
Does This PR Require a Contrib Repo Change?
Checklist: