Add line-specific filter to catch warning #3164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ocelotl
commented
Feb 6, 2023
opentelemetry-sdk/src/opentelemetry/sdk/metrics/_internal/export/__init__.py
Show resolved
Hide resolved
ocelotl
commented
Feb 6, 2023
opentelemetry-sdk/tests/metrics/test_periodic_exporting_metric_reader.py
Show resolved
Hide resolved
ocelotl
commented
Feb 6, 2023
opentelemetry-sdk/tests/metrics/test_periodic_exporting_metric_reader.py
Show resolved
Hide resolved
ocelotl
commented
Feb 6, 2023
opentelemetry-sdk/tests/metrics/test_periodic_exporting_metric_reader.py
Show resolved
Hide resolved
shalevr
reviewed
Feb 8, 2023
lzchen
reviewed
Feb 8, 2023
lzchen
reviewed
Feb 8, 2023
shalevr
reviewed
Feb 8, 2023
shalevr
approved these changes
Feb 9, 2023
srikanthccv
approved these changes
Feb 10, 2023
lzchen
approved these changes
Feb 13, 2023
6 tasks
|
Thanks! This fixes the immediate bug of warnings being wrongfully enabled, but it doesn't fix the underlying issue of the need to work around this specific deprecation warning. I'm not familiar with the project, so I could be wrong, but it seems to me like the real fix for this issue would be to stop using the deprecated function in the first place. If the workaround is a temporary measure to bridge the gap between deprecation and complete removal of the function, then it might be worth adding a comment about it as a note to people unfamiliar with the reason behind it, and as a reminder to clean it up later 🙂 |
cojenco
added a commit
to cojenco/python-storage
that referenced
this pull request
May 23, 2024
cojenco
added a commit
to googleapis/python-storage
that referenced
this pull request
May 30, 2024
* feat: OTel tracing media ops initial instrumentation * use download class name as span name * avoid asserting filtered warnings from otel per open-telemetry/opentelemetry-python#3164
cojenco
added a commit
to googleapis/python-storage
that referenced
this pull request
Jun 26, 2024
* feat: introduce OpenTelemetry Tracing decorators (#1257) * feat: introduce OpenTelemetry Tracing decorators * update test coverage * add tests, update fixture * update noxfile, extras; remove print * update unit test * review comments * feat: instrument metadata ops with OTel tracing (#2) (#1267) * feat: instrument metadata ops with Otel tracing * update README plus test * update decorator name per review session * fix typo in readme * feat: OTel tracing media ops initial instrumentation (#1280) * feat: OTel tracing media ops initial instrumentation * use download class name as span name * avoid asserting filtered warnings from otel per open-telemetry/opentelemetry-python#3164 * add copyright and preview note * comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3163
This is another approach to solve the issue #3147 intends to solve but without using
catch_warningswhich is not thread-safe.