-
Notifications
You must be signed in to change notification settings - Fork 893
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor messaging attributes and specify per-message attributes #2957
Refactor messaging attributes and specify per-message attributes #2957
Conversation
bb6e939
to
57ec5e8
Compare
d80d135
to
f4811cb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did a first pass on the yaml file, looking great! I will take a look at the rest later and submit a new review then.
f4811cb
to
9b249a9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wanted to do another pass before the meeting, but only got around it today.
@lmolkova Can you please rebase? This should fix the failing markdown-link build job. |
307ede1
to
b896623
Compare
Co-authored-by: Joao Grassi <joao@joaograssi.com>
…orresponding groups
Co-authored-by: Johannes Tax <johannes@johannes.tax> Co-authored-by: Joao Grassi <joao@joaograssi.com>
Co-authored-by: Joao Grassi <joao@joaograssi.com>
Co-authored-by: Joao Grassi <joao@joaograssi.com>
7fe171c
to
084d6db
Compare
The final round of #2763
Changes
Messaging instrumentation SIG is working on spec changes and this change is one of the first steps to bring the consensus we reached in SIG to the spec.
This change introduces different namespace for different kinds of attributes:
messaging.message
for message properties (e.g. message id or payload size)messaging.destination
for producers to describe publish operations (e.g. queue name)messaging.source
for consumers to describe receive/deliver/process operations (e.g. queue name)messaging.batch
for to describe batch properties (e.g. message count)messaging.consumer
for to describe consumer properties (e.g. consumer id)It also introduces guidance for specific systems on namespaces.
Here's the list of breaking changes (attribute renames):
messaging.protocol
:net.app.protocol.name
messaging.protocol_version: net.app.protocol.version
messaging.destination: messaging.destination.name
messaging.temp_destination: messaging.destination.temporary
messaging.destination_kind: messaging.destination.kind
messaging.message_id
:messaging.message.id
messaging.conversation_id
:messaging.message.conversation_id
messaging.message_payload_size_bytes
:messaging.message.payload_size_bytes
messaging.message_payload_compressed_size_bytes
:messaging.message.payload_compressed_size_bytes
messaging.rabbitmq.routing_key
:messaging.rabbitmq.message.routing_key
messaging.kafka.message_key
:messaging.kafka.message.key
messaging.kafka.partition
:messaging.kafka.message.partition
messaging.kafka.tombstone
:messaging.kafka.message.tombstone
messaging.rocketmq.message_type
:messaging.rocketmq.message.type
messaging.rocketmq.message_tag
:messaging.rocketmq.message.tag
messaging.rocketmq.message_keys
:messaging.rocketmq.message.keys
It also adds the
messaging.batch.message_count
attribute which intends to:Related OTEP(s) #