Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide clear guidance on what semconv actually enforces #3225

Merged
merged 46 commits into from
Apr 3, 2023
Merged

Provide clear guidance on what semconv actually enforces #3225

merged 46 commits into from
Apr 3, 2023

Conversation

jsuereth
Copy link
Contributor

Fixes #2864
Fixes #2883

Changes

  • Explicitly define what is "enforced" by stability guarantees from Semantic conventions.
    • We enforce attribute key names + types, across resource, span, metric and log
    • We enforce span names
    • We enforce metric names, units
  • Expand allowed changes to semconv to include metric attributes that do not increase timeseries count for a given metric.

Context

Sig discussion thread/doc here.

@jsuereth
Fix open-telemetry#2864 with more clear guidance on what is enforced …
f037c83 
…by semconv that can be included in stability.
@jsuereth jsuereth requested review from a team February 17, 2023 14:57
trask
trask reviewed Feb 17, 2023
View reviewed changes
specification/versioning-and-stability.md Outdated Show resolved Hide resolved
specification/versioning-and-stability.md Outdated Show resolved Hide resolved
jsuereth and others added 2 commits February 17, 2023 12:28
@jsuereth @trask
Update specification/versioning-and-stability.md
f1890e8 
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
@jsuereth @trask
Update specification/versioning-and-stability.md
a4f8505 
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
@trask trask mentioned this pull request Feb 17, 2023
Closed
@arminru arminru mentioned this pull request Feb 21, 2023
Merged
tigrannajaryan
tigrannajaryan reviewed Feb 21, 2023
View reviewed changes
Copy link
Member

@tigrannajaryan tigrannajaryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for tackling this @jsuereth
I think it is important to define precisely what we guarantee.

specification/versioning-and-stability.md Outdated Show resolved Hide resolved
specification/versioning-and-stability.md Outdated Show resolved Hide resolved
specification/versioning-and-stability.md Outdated Show resolved Hide resolved
specification/versioning-and-stability.md Outdated Show resolved Hide resolved
specification/versioning-and-stability.md Outdated Show resolved Hide resolved
specification/versioning-and-stability.md Show resolved Hide resolved
jsuereth and others added 10 commits February 21, 2023 15:01
@jsuereth @tigrannajaryan
Update specification/versioning-and-stability.md
cb088de 
Co-authored-by: Tigran Najaryan <4194920+tigrannajaryan@users.noreply.github.com>
@chalin @jsuereth
[editorial] Fix Tencent Cloud link (open-telemetry#3231)
e67cdb1
@SergeyKanzhelev @jsuereth
Remove SergeyKanzhelev from auto-assignment (open-telemetry#3229)
bfc0709
@chalin @jsuereth
Update supplementary-guidelines.md (open-telemetry#3230)
4911aca
@chalin @carlosalberto @jsuereth
[editorial] normalize link to prometheus docs (open-telemetry#3232)
403a298 
Co-authored-by: Carlos Alberto Cortez <calberto.cortez@gmail.com>
@tylerbenson @jsuereth
Rename faas.execution to faas.invocation_id and change units for …
77137f0 
…`faas.max_memory` (open-telemetry#3209)
@joshcarp @arminru @jsuereth
Add Connect RPC to semantic conventions (open-telemetry#3116)
831a045 
* Add connect_rpc to rpc.yaml

* Add connect rpc into rpc-metrics and rpc markdown

* Add Connect RPC change to CHANGELOG.md

* Update CHANGELOG.md

---------

Co-authored-by: Armin Ruech <armin.ruech@dynatrace.com>
@chalin @yurishkuro @jsuereth
Update data-model.md (open-telemetry#3233)
87ddbcd 
Co-authored-by: Yuri Shkuro <yurishkuro@users.noreply.github.com>
@asafm @jsuereth
Add unit to Instrument selection criteria (open-telemetry#3184)
5316e5f
@moonbox3 @jsuereth
Fix typos and grammar in the OTLP spec (open-telemetry#3121)
75d40a6
@trask trask mentioned this pull request Mar 2, 2023
Open
jsuereth and others added 4 commits March 2, 2023 11:23
@jsuereth @trask
Update specification/versioning-and-stability.md
7e7e626 
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
@jsuereth @trask
Update specification/versioning-and-stability.md
871c103 
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
@jsuereth @trask
Update specification/versioning-and-stability.md
2723805 
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
@jsuereth @trask
Update specification/versioning-and-stability.md
43e083a 
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
@lmolkova lmolkova mentioned this pull request Mar 3, 2023
Closed
@jsuereth @jack-berg
Update specification/versioning-and-stability.md
f27bb26 
Co-authored-by: jack-berg <34418638+jack-berg@users.noreply.github.com>
lmolkova
lmolkova reviewed Mar 6, 2023
View reviewed changes
Copy link
Contributor

@lmolkova lmolkova left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no objection to additions done in the PR, but I still have concern wrt schema transformation and how/if it can really guarantee stability and work along with this PR.

I created #3296 and suggest that we keep schema transformations experimental with possibility to stabilize it in the future independently of current efforts to stabilize HTTP semconv.

specification/versioning-and-stability.md Outdated Show resolved Hide resolved
specification/versioning-and-stability.md Outdated Show resolved Hide resolved
@jsuereth @lmolkova
Update specification/versioning-and-stability.md
af69829 
Co-authored-by: Liudmila Molkova <limolkova@microsoft.com>
@jmacd jmacd merged commit 713ae0d into open-telemetry:main Apr 3, 2023
@jsuereth jsuereth deleted the pr-metric-stability branch April 3, 2023 16:38
@jsuereth jsuereth mentioned this pull request Jun 26, 2023
Closed
@Oberon00 Oberon00 mentioned this pull request Jun 27, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trask trask trask approved these changes

@Oberon00 Oberon00 Oberon00 left review comments

@lmolkova lmolkova lmolkova approved these changes

@yurishkuro yurishkuro yurishkuro left review comments

@jmacd jmacd jmacd left review comments

@tigrannajaryan tigrannajaryan tigrannajaryan left review comments

@arminru arminru arminru left review comments

@MSNev MSNev MSNev left review comments

@jpkrohling jpkrohling jpkrohling approved these changes

@pyohannes pyohannes pyohannes approved these changes

@reyang reyang reyang approved these changes

@jack-berg jack-berg jack-berg approved these changes

Assignees

@jmacd jmacd

Labels
None yet
Projects
None yet
Milestone
No milestone