-
Notifications
You must be signed in to change notification settings - Fork 893
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 1.21.0 #3474
Release 1.21.0 #3474
Conversation
would we also drop the semantic convention changes from the change log in this case? i'm ok either way, just want to check |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Blocking for now to coordinate the semantic convention changes open-telemetry/oteps#227.
Here is my understanding of the plan based on the TC discussion/meeting:
- 1. 1.21.0 release from the spec repo will not include semantic convention.
- 2. We aim to have Separate semantic conventions from the specification. oteps#227 merged next Monday/Tuesday (May. 8th/9th, 2023).
- 3. @jsuereth will create the new repo https://github.com/open-telemetry/semantic-conventions.
- 4. We expect semantic conventions PRs to move to https://github.com/open-telemetry/semantic-conventions; for certain big PRs that we've already spent lots of efforts and received multiple approvals, it is okay to merge them into the current spec repo given we don't plan to release from the spec repo anyways. The semantic convention YAML/Markdown files will be cherry picked and added to the new repo.
- 5. We'll clean up the spec repo, all the semantic conventions YAML file and related tools/CI will be removed, markdown files will be kept but the content will be replaced with a notice and link to the new place (this is for folks who accidentally use a non-permanent link).
- 6. The release note of 1.21.0 will be sanitized, with a notice that semantic convention has moved to a new place and there won't be new semantic convention release from this repo anymore.
Actually the related OTEP is merged. But Tuesday still sounds good as a target day to complete the remaining steps. Thanks for adding the details on the following steps @reyang ! |
@carlosalberto @jsuereth @trask FYI, these are the open PRs that should move to https://github.com/open-telemetry/semantic-conventions (to be created this week) repo. @jsuereth please let me know once you got the new repo created, I can handle the following parts in the next two days:
|
I think we need to remove (or somehow make sure it is not published) schema file 1.21.0. We are not releasing a new schema with this spec release, right? So, it should not be published. |
Yes, this is bullet point 5 in #3474 (review). |
@open-telemetry/specs-approvers Please review. |
Bullet point 4 in #3474 (review) is about moving PR. Should the open issues on area:semantic-conventions be moved to the new repo as well ? |
May Release.
May Release.
We will most likely leave schema publishing out of this when open-telemetry/oteps#227 is merged (releases for the schema will happen from the new repo). In the meantime, please review the included changes for this release.