Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 1.21.0 #3474

Merged
merged 5 commits into from
May 16, 2023
Merged

Conversation

carlosalberto
Copy link
Contributor

May Release.

We will most likely leave schema publishing out of this when open-telemetry/oteps#227 is merged (releases for the schema will happen from the new repo). In the meantime, please review the included changes for this release.

@carlosalberto carlosalberto requested review from a team May 5, 2023 13:53
@trask
Copy link
Member

trask commented May 5, 2023

We will most likely leave schema publishing out of this when open-telemetry/oteps#227 is merged (releases for the schema will happen from the new repo).

would we also drop the semantic convention changes from the change log in this case?

i'm ok either way, just want to check

@carlosalberto
Copy link
Contributor Author

@trask I think so, yes. Once the mentioned OTEP is merged (we already have enough approvals), @jsuereth will split the existing semconv into a new repo, so we will be adjusting things around.

reyang
reyang previously requested changes May 5, 2023
Copy link
Member

@reyang reyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking for now to coordinate the semantic convention changes open-telemetry/oteps#227.

Here is my understanding of the plan based on the TC discussion/meeting:

@carlosalberto
Copy link
Contributor Author

Actually the related OTEP is merged. But Tuesday still sounds good as a target day to complete the remaining steps. Thanks for adding the details on the following steps @reyang !

@reyang
Copy link
Member

reyang commented May 9, 2023

@carlosalberto @jsuereth @trask FYI, these are the open PRs that should move to https://github.com/open-telemetry/semantic-conventions (to be created this week) repo.

@jsuereth please let me know once you got the new repo created, I can handle the following parts in the next two days:

  1. Close these PRs https://github.com/open-telemetry/opentelemetry-specification/pulls?q=is%3Apr+is%3Aopen+label%3Aarea%3Asemantic-conventions, notify the owner to resubmit them in the new repo.
  2. Update the PR template in this (spec) repo.

@tigrannajaryan
Copy link
Member

I think we need to remove (or somehow make sure it is not published) schema file 1.21.0. We are not releasing a new schema with this spec release, right? So, it should not be published.

@reyang
Copy link
Member

reyang commented May 9, 2023

I think we need to remove (or somehow make sure it is not published) schema file 1.21.0. We are not releasing a new schema with this spec release, right? So, it should not be published.

Yes, this is bullet point 5 in #3474 (review).

@reyang reyang requested a review from jsuereth May 9, 2023 21:28
@carlosalberto
Copy link
Contributor Author

@jsuereth @reyang I have removed the semantic conventions section from the CHANGELOG, just FYI.

@carlosalberto
Copy link
Contributor Author

@open-telemetry/specs-approvers Please review.

@marcalff
Copy link
Member

Bullet point 4 in #3474 (review) is about moving PR.

Should the open issues on area:semantic-conventions be moved to the new repo as well ?

@reyang reyang dismissed their stale review May 15, 2023 22:20

Being addressed in #3506

@carlosalberto carlosalberto merged commit 4229197 into open-telemetry:main May 16, 2023
@carlosalberto carlosalberto deleted the release-1-21-0 branch May 16, 2023 22:28
carlosalberto added a commit to carlosalberto/opentelemetry-specification that referenced this pull request Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants