-
Notifications
You must be signed in to change notification settings - Fork 893
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarification: metric namespaces are allowed to be metric names #3477
Clarification: metric namespaces are allowed to be metric names #3477
Conversation
ce1c327
to
9ae1522
Compare
@trask heads up - most likely this PR will be closed, and we'll ask you to resubmit the PR in a new repo, please refer to #3474 (comment). |
One big upside to this proposal as compared to #3476 is that allowing it for metrics enables us to drop |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm also in favor of this for the many reasons others pointed in the discussions. I believe preventing "namespaces" to be metrics names themselves would be very limiting.
We anyway have to apply judgment and good sense, because making this explicit now, doesn't mean adding a metric such as process.runtime.jvm
is allowed, even though it "complies" with the wording added here. But that's what the review process is for anyway :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please move this to https://github.com/open-telemetry/semantic-conventions
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
hey all, the @open-telemetry/technical-committee is reviewing this issue, and asked to create a summary of pros/cons. I have created open-telemetry/semantic-conventions#50 based on the comments here, please comment further over there if I missed anything, thx! |
Related to #3457 (comment)
Note that this is different from attribute namespaces which are not allowed to coincide with attribute names:
See alternative proposal (that metric namespaces ARE NOT allowed to be metric names) at #3476
Changes
Clarifies that metric namespaces are allowed to be metric names.