Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename/replace (client|server).socket.(address|port) attributes with network.(peer|local).(address|port). #3713

Merged
merged 4 commits into from
Oct 23, 2023

Conversation

trask
Copy link
Member

@trask trask commented Oct 3, 2023

Queuing this PR so I don't forget once open-telemetry/semantic-conventions#342 is (hopefully) merged. open-telemetry/semantic-conventions#342 is merged now

Changes

Rename/replace (client|server).socket.(address|port) attributes with network.(peer|local).(address|port).

@trask trask marked this pull request as ready for review October 3, 2023 21:10
@trask trask requested review from a team October 3, 2023 21:10
@arminru arminru merged commit 082207b into open-telemetry:main Oct 23, 2023
7 checks passed
carlosalberto pushed a commit that referenced this pull request Jan 9, 2024
Fixes
#3793

## Changes

Update OpenTelemetry to Zipkin Transformation to handle attributes from
older semantic conventions in a backwards compatible way so that
following attributes are (again) handled:
- `net.peer.name`
- `net.host.name`
- `net.sock.peer.addr` & `net.sock.peer.port`
- `server.socket.domain`
- `server.socket.address` & `server.socket.port`

The backwards compatibility of a stable OpenTelemetry to Zipkin
Transformation was broken by:
-
#3402
-
#3713
carlosalberto pushed a commit to carlosalberto/opentelemetry-specification that referenced this pull request Oct 31, 2024
…h `network.(peer|local).(address|port)`. (open-telemetry#3713)

Co-authored-by: Armin Ruech <armin.ruech@dynatrace.com>
carlosalberto pushed a commit to carlosalberto/opentelemetry-specification that referenced this pull request Oct 31, 2024
Fixes
open-telemetry#3793

## Changes

Update OpenTelemetry to Zipkin Transformation to handle attributes from
older semantic conventions in a backwards compatible way so that
following attributes are (again) handled:
- `net.peer.name`
- `net.host.name`
- `net.sock.peer.addr` & `net.sock.peer.port`
- `server.socket.domain`
- `server.socket.address` & `server.socket.port`

The backwards compatibility of a stable OpenTelemetry to Zipkin
Transformation was broken by:
-
open-telemetry#3402
-
open-telemetry#3713
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants