Fix CODEOWNERS syntax #670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oberon00
reviewed
Jun 24, 2020
CODEOWNERS
Outdated
| @@ -16,13 +16,13 @@ | |||
| * @specs-approvers | |||
There was a problem hiding this comment.
Are you sure this is the problem? Seems to work fine for this PR:
There was a problem hiding this comment.
Ah, you requested it manually. 🙈 Then the line I commented on should also be fixed.
There was a problem hiding this comment.
Yep! Missed that one, thanks.
Oberon00
approved these changes
Jun 24, 2020
|
Apparently having no code owners means that I can give a green checkmark |
carlosalberto
approved these changes
Jun 24, 2020
|
Let's give it a run! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current CODEOWNERS definition doesn't work (see #669, where no reviewers were added, I requested @open-telemetry/specs-trace-approvers manually). Teams have to be mentioned as
@org/team-name(see https://help.github.com/en/github/creating-cloning-and-archiving-repositories/about-code-owners#codeowners-syntax).