Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CODEOWNERS syntax #670

Merged
merged 2 commits into from
Jun 24, 2020
Merged

Fix CODEOWNERS syntax #670

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fc1614b
Fix CODEOWNERS syntax
arminru Jun 24, 2020
4562efb
Fix CODEOWNERS syntax
arminru Jun 24, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions CODEOWNERS
View file
Open in desktop
Validating CODEOWNERS rules …
Original file line number Diff line number Diff line change
Expand Up @@ -16,13 +16,13 @@
* @specs-approvers
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure this is the problem? Seems to work fine for this PR:

image

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, you requested it manually. 🙈 Then the line I commented on should also be fixed.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep! Missed that one, thanks.


# Trace owners (global + trace)
experimental/trace/ @specs-approvers @specs-trace-approvers
specification/trace/ @specs-approvers @specs-trace-approvers
experimental/trace/ @open-telemetry/specs-approvers @open-telemetry/specs-trace-approvers
specification/trace/ @open-telemetry/specs-approvers @open-telemetry/specs-trace-approvers

# Metrics owners (global + metrics)
experimental/metrics/ @specs-approvers @specs-metrics-approvers
specification/metrics/ @specs-approvers @specs-metrics-approvers
experimental/metrics/ @open-telemetry/specs-approvers @open-telemetry/specs-metrics-approvers
specification/metrics/ @open-telemetry/specs-approvers @open-telemetry/specs-metrics-approvers

# Logs owners (global + logs)
experimental/logs/ @specs-approvers @specs-logs-approvers
specification/logs/ @specs-approvers @specs-logs-approvers
experimental/logs/ @open-telemetry/specs-approvers @open-telemetry/specs-logs-approvers
specification/logs/ @open-telemetry/specs-approvers @open-telemetry/specs-logs-approvers