-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adjust to move Semantic Conventions out of OTel spec #2721
Comments
Note that I've closed the following PR since the semconv pages have moved |
@chalin Let me know how best we can start moving this issue forward. Happy to have you at the semconv working group to explain what you need to us, or we can attend whatever SiG/WGs meetings you attend. |
@jsuereth - I was OOO. Catching up now. I didn't have the time to work on this before I left. I see that you've submitted a PR. I'll take a look as soon as I can. |
Oh, I remember that I had issues regarding the structure of the semconv repo docs. I'll write more about that soon. |
Hi @chalin, I volunteered to take up this work on the semconv repo side. Let me know how we can best work together. I'm available on Slack as well. |
@jsuereth @joaopgrassi - I see from the following that you'll be restructuring the spec: Do you want to wait for that restructuring to land before starting to publish the semconv spec on the website? |
Hi @joaopgrassi @jsuereth: I see that part of the work has already been done in My suggestion would be to bring in the changes incrementally and delay publishing anything to the production server until work on open-telemetry/semantic-conventions#137 is complete. That way we can avoid having to introduce a bunch of redirect rules. WDYT? |
In terms of bringing things in incrementally, here's a first PR: PTAL |
Yeah I think that would be best, to avoid double work. I will be helping out in the restructuring so should be "quick" |
Questions from #2920 (review):
That will happen automatically once the semconv reorg lands.
Yes. I didn't address this yet because the semconv pages currently link directly to v1.21.0 of the OTel spec, whereas the website is now hosting v1.22.0.
Yes, once we're closer to publishing the new semconv spec, I can work on addressing this. |
Thanks @chalin ! I can bump semconv to the 1.22.0 version of the specification prior to release if that helps. Let me know if there's any of this I can help out with! I'm glad my PR helped outline something useful, should I close it at this point? |
If you are ok with the semconv pages linking to the OTel spec on the website, regardless of the spec version specified in the link reference, then I can handle that with the adjustment script. No need to bump the version to 1.22.0. Yes you can close the other PR. |
Hi @chalin the restructure is now done. How should we tackle the website work now? |
We need to wait for the following, right? |
@chalin Looks like we merged that change. I'm working on something local to fix the import, but running into some issues figuring out hugo. Maybe we sync in the (EDT) morning? |
@chalin Do you think enough work has been done on the Semantic Convention repository that we could cut a release tag to continue the work on the website? (Showing the version and bumping to the release version). I'm assuming that's the case from your last PR, but wanted to confirm before we cut a release. |
Hi @jsuereth - oh, I missed your request to sync last Friday because I ended early. I'm catching up on notifications now. I'd like to bring in the latest semconv, clean up the scripts and make sure that all is good. Cutting a release is seems reasonable. |
@chalin Great. The goal is to bump the spec version and cut our |
The |
FYI - With this tag, we need to start serving the |
Does this mean that all schemas in that directory are to be served? If so, I'll submit a PR doing that now. |
Does this also mean that we can publish the semconv pages to the production server? |
@jsuereth - while there will be ongoing work to support semconv and other specs, can we close this issue considering that the bulk of the work has been done? |
We're well beyond the original migration effort. Closing. Feel free to comment here if you'd like this to stay open. |
As part of OTEP #227 we're moving the semantic conventions out of the Specification and into a new repository.
As part of this:
We may be re-architecting the structure of this repository, but we can negotiate how best to do so for the website to easily pull it in.
Tasks
README.md
for Resource Cloud Provider semconv semantic-conventions#171/docs/specs/otel
)|(/resource/faas\.md)#function-as-a-service|$1|;
- [editorial] Link directly to page, not to page's title semantic-conventions#180.warnings-skip-list.txt
.warnings-skip-list.txt
(after CI: check-links: enable caching and check for warnings #3026 is merged)Other to-dos from #2908:
specification/semantic_conventions/*.md
from being pulled in OpenTelemetry specification.supplementary-guidelines
to be underdocs
semantic-conventions#1240The text was updated successfully, but these errors were encountered: