Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust to move Semantic Conventions out of OTel spec #2721

Closed
29 of 33 tasks
Tracked by #2793 ...
jsuereth opened this issue May 15, 2023 · 24 comments
Closed
29 of 33 tasks
Tracked by #2793 ...

Adjust to move Semantic Conventions out of OTel spec #2721

jsuereth opened this issue May 15, 2023 · 24 comments
Labels
CI/infra CI & infrastructure

Comments

@jsuereth
Copy link

jsuereth commented May 15, 2023

As part of OTEP #227 we're moving the semantic conventions out of the Specification and into a new repository.

As part of this:

We may be re-architecting the structure of this repository, but we can negotiate how best to do so for the website to easily pull it in.


Tasks

Other to-dos from #2908:

  • Add semantic conventions to ToC / index
  • Ensure semantic-conventions -> specification links are accurately internalized to the website
  • Ensure specification -> semantic-conventions links are accurately internalized to the website.
  • Remove specification/semantic_conventions/*.md from being pulled in OpenTelemetry specification.
  • Figure out if supplementary guidelines belong on the website --> [editorial] Move supplementary-guidelines to be under docs semantic-conventions#1240
@chalin
Copy link
Contributor

chalin commented May 24, 2023

Note that I've closed the following PR since the semconv pages have moved

@jsuereth
Copy link
Author

@chalin Let me know how best we can start moving this issue forward. Happy to have you at the semconv working group to explain what you need to us, or we can attend whatever SiG/WGs meetings you attend.

@chalin
Copy link
Contributor

chalin commented Jun 26, 2023

@jsuereth - I was OOO. Catching up now. I didn't have the time to work on this before I left. I see that you've submitted a PR. I'll take a look as soon as I can.

@chalin
Copy link
Contributor

chalin commented Jun 26, 2023

Oh, I remember that I had issues regarding the structure of the semconv repo docs. I'll write more about that soon.

@joaopgrassi
Copy link
Member

Hi @chalin, I volunteered to take up this work on the semconv repo side. Let me know how we can best work together. I'm available on Slack as well.

@chalin
Copy link
Contributor

chalin commented Jun 27, 2023

@jsuereth @joaopgrassi - I see from the following that you'll be restructuring the spec:

Do you want to wait for that restructuring to land before starting to publish the semconv spec on the website?

@chalin
Copy link
Contributor

chalin commented Jun 27, 2023

Hi @joaopgrassi @jsuereth: I see that part of the work has already been done in

My suggestion would be to bring in the changes incrementally and delay publishing anything to the production server until work on open-telemetry/semantic-conventions#137 is complete. That way we can avoid having to introduce a bunch of redirect rules. WDYT?

@chalin chalin changed the title Adjust to move Semantic Conventions out of specification Adjust to move Semantic Conventions out of OTel spec Jun 27, 2023
@chalin
Copy link
Contributor

chalin commented Jun 27, 2023

In terms of bringing things in incrementally, here's a first PR:

PTAL

@joaopgrassi
Copy link
Member

Do you want to wait for that restructuring to land before starting to publish the semconv spec on the website?

Yeah I think that would be best, to avoid double work. I will be helping out in the restructuring so should be "quick"

@chalin
Copy link
Contributor

chalin commented Jun 28, 2023

Questions from #2920 (review):

  • How do we get left-hand outline like the spec has for sections?

That will happen automatically once the semconv reorg lands.

  • Can we change all links to specification in semconv to point at the otel.io copy of the specification?

Yes. I didn't address this yet because the semconv pages currently link directly to v1.21.0 of the OTel spec, whereas the website is now hosting v1.22.0.

  • Can we change all links to semconv from the specification to point at the otel.io copy of the semconv?

Yes, once we're closer to publishing the new semconv spec, I can work on addressing this.

@jsuereth
Copy link
Author

Thanks @chalin !

I can bump semconv to the 1.22.0 version of the specification prior to release if that helps.

Let me know if there's any of this I can help out with! I'm glad my PR helped outline something useful, should I close it at this point?

@chalin
Copy link
Contributor

chalin commented Jun 28, 2023

If you are ok with the semconv pages linking to the OTel spec on the website, regardless of the spec version specified in the link reference, then I can handle that with the adjustment script. No need to bump the version to 1.22.0.

Yes you can close the other PR.

@joaopgrassi
Copy link
Member

Hi @chalin the restructure is now done. How should we tackle the website work now?

@chalin
Copy link
Contributor

chalin commented Jul 6, 2023

@jsuereth
Copy link
Author

jsuereth commented Jul 6, 2023

@chalin Looks like we merged that change. I'm working on something local to fix the import, but running into some issues figuring out hugo. Maybe we sync in the (EDT) morning?

@jsuereth
Copy link
Author

@chalin Do you think enough work has been done on the Semantic Convention repository that we could cut a release tag to continue the work on the website? (Showing the version and bumping to the release version).

I'm assuming that's the case from your last PR, but wanted to confirm before we cut a release.

@chalin
Copy link
Contributor

chalin commented Jul 10, 2023

Hi @jsuereth - oh, I missed your request to sync last Friday because I ended early. I'm catching up on notifications now. I'd like to bring in the latest semconv, clean up the scripts and make sure that all is good. Cutting a release is seems reasonable.

@jsuereth
Copy link
Author

@chalin Great. The goal is to bump the spec version and cut our 1.22.1 release of semantic conventions wed-ish timeframe. Will ping this thread when the release is cut.

@jsuereth
Copy link
Author

The v1.12.1 tag has been cut.

@jsuereth
Copy link
Author

FYI - With this tag, we need to start serving the 1.21.0 file under the schemas/ directory.

@chalin
Copy link
Contributor

chalin commented Jul 14, 2023

Does this mean that all schemas in that directory are to be served? If so, I'll submit a PR doing that now.

@chalin
Copy link
Contributor

chalin commented Jul 14, 2023

Does this also mean that we can publish the semconv pages to the production server?

@chalin
Copy link
Contributor

chalin commented Oct 31, 2023

@jsuereth - while there will be ongoing work to support semconv and other specs, can we close this issue considering that the bulk of the work has been done?

@chalin
Copy link
Contributor

chalin commented Jul 25, 2024

We're well beyond the original migration effort. Closing. Feel free to comment here if you'd like this to stay open.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/infra CI & infrastructure
Projects
None yet
Development

No branches or pull requests

4 participants