-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SemConv spec under docs/specs (preview) #2920
Add SemConv spec under docs/specs (preview) #2920
Conversation
ce8c83f
to
9d55c57
Compare
Thanks for the review @cartermp! Will wait for feedback from @jsuereth and @joaopgrassi. |
Yep, figured as much |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, given things will change after #137.
One question though: Do you think the structure defined here open-telemetry/semantic-conventions#137 (comment) is possible to reproduce on the website? Or: Does it even make sense to you?
@@ -185,6 +185,14 @@ module: | |||
target: content/docs/specs/otlp/_index.md | |||
- source: tmp/otlp/docs/img | |||
target: content/docs/specs/otlp/img | |||
- source: tmp/semconv/specification/logs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're going through a refactoring of the semantic conventions markdown right now.
Can we just mount tmp/semconv/specification
? There will be a top-level readme file there shortly and I'm happy to give it all the hugo content you need.
We do not want to have logs/metrics/trace specific locations going forward.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've answered further below.
@joaopgrassi - yes, it will actually be easier to bring in. This is just a preview of what it would look like under the current organization.
@jsuereth - right, this PR is just in preparation, while open-telemetry/semantic-conventions#137 is being addressed. I'd you agree (and approve this PR @jsuereth), I'd like to merge this PR As I mentioned earlier, the semconv spec will not show up in production. As work progresses on in the semconv repo, I can submit followup PRs. |
323326f
to
d03053e
Compare
@jsuereth @joaopgrassi - btw, regarding the It's a detail, not very important, but I wanted to at least explain why so that you can make a more informed choice of what you'd like the |
FYI - This relates to the previous PR in this chain, but something we should fix ASAP: open-telemetry/opentelemetry-specification#3572 |
I see. I think the word wrap isn't great, but I think I prefer that over the "cryptic" SemConv one. But even in my 1080p monitor there was no wrap, so should be OK? I guess if it comes to that, we can do some css magic :D |
Also: We will be listing under "Semantic Conventions" just the "latest version" right? We will not have something like
|
@joaopgrassi - correct, only the latest officially released version (at least, that is what we're doing with the OTel spec, and we can do the same here). |
Co-authored-by: Joao Grassi <joao@joaograssi.com>
d03053e
to
82c1160
Compare
@jsuereth - so, is this preview PR good to go? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Under the caveat that we'll change the import going forward for new layout, yeah, let's keep making steady progress.
I do have a few question for follow up PRs:
- How do we get left-hand outline like the spec has for sections?
- Can we change all links to specification in semconv to point at the otel.io copy of the specification?
- Can we change all links to semconv from the specification to point at the otel.io copy of the semconv?
For the last two I was working on the perl script to make this happen.
@jsuereth - I've answered in #2721 (comment). |
docs/specs
draft: true
Feature Request: Restructure Semantic Convention markdown to be topical vs. by signal semantic-conventions#137
Preview: https://deploy-preview-2920--opentelemetry.netlify.app/docs/specs/semconv/
/cc @jsuereth @joaopgrassi