-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[editorial] Fix doc page titles and add Hugo front matter #175
[editorial] Fix doc page titles and add Hugo front matter #175
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing all this work!
I have a meta-question related to how we keep this hugo matter up to date, given the pace at which we've been adding docs.
TL;DR; we either need a guide on how/what to fill out and when or for some of this can we move it into the docs adjust-pages.pl
script?
@jsuereth - you make good points about some of the front matter. To answer your questions:
Would it be ok for this PR to land, and we address your concerns (regarding |
3f7edac
to
29ea735
Compare
I've rebased and re-normalized the new and updated doc pages. |
Yes, depending on the answer to this question: If we add new markdown files that do NOT include appropriate hugo frontmatter/github redirect, does it fundamentally break the website? If the answer is YES, I think we should add a |
@jsuereth - no, not having front matter for new files will not break the website build, and the page will get published. The |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! Thanks for all the fixes, this looks good to go.
/cc @svrnm @cartermp @jsuereth @joaopgrassi