Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Go] Bump to newer semconv #3838

Merged
merged 2 commits into from
Jan 22, 2024
Merged

[Go] Bump to newer semconv #3838

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d9864d6
[Go] Bump to newer semconv
pellared Jan 22, 2024
1f54edc
Merge branch 'main' into pellared-patch-1
pellared Jan 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion content/en/docs/languages/go/getting-started.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ go get "go.opentelemetry.io/otel" \
"go.opentelemetry.io/otel/sdk/metric" \
"go.opentelemetry.io/otel/sdk/resource" \
"go.opentelemetry.io/otel/sdk/trace" \
"go.opentelemetry.io/otel/semconv/v1.21.0" \
"go.opentelemetry.io/otel/semconv/v1.24.0" \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

non blocking comment, @open-telemetry/go-approvers: we can implement an automatic version updating similar to what java, collector, etc have:

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could be nice. However, take notice that the version is not equal version of OTel Go. It may not be easy to create such script.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also for java we have different versions for SDK, semconv, etc. So we might be able to replicate that.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also created open-telemetry/opentelemetry-go#4846 so that at least the example would not break in runtime if the code uses an older version of semconv.

"go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp"
```

Expand Down
Loading