-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Go] Bump to newer semconv #3838
Conversation
@open-telemetry/go-approvers Do you think that here opentelemetry.io/content/en/docs/languages/go/getting-started.md Lines 196 to 202 in 6e3bf58
it would be better to use Related to open-telemetry/opentelemetry-go#2341 |
@@ -104,7 +104,7 @@ go get "go.opentelemetry.io/otel" \ | |||
"go.opentelemetry.io/otel/sdk/metric" \ | |||
"go.opentelemetry.io/otel/sdk/resource" \ | |||
"go.opentelemetry.io/otel/sdk/trace" \ | |||
"go.opentelemetry.io/otel/semconv/v1.21.0" \ | |||
"go.opentelemetry.io/otel/semconv/v1.24.0" \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
non blocking comment, @open-telemetry/go-approvers: we can implement an automatic version updating similar to what java, collector, etc have:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This could be nice. However, take notice that the version is not equal version of OTel Go. It may not be easy to create such script.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also for java we have different versions for SDK, semconv, etc. So we might be able to replicate that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also created open-telemetry/opentelemetry-go#4846 so that at least the example would not break in runtime if the code uses an older version of semconv.
@pellared feel free to merge when you feel you've gotten enough feedback from other folks on the Go SIG for your question. Otherwise, I'll plan to merge by end of week. |
@cartermp Can you merge it? This one is a trivial fix. It just propagates the changes: https://github.com/open-telemetry/opentelemetry-go/blob/main/example/dice/otel.go#L29 I will propose a solution that does not require bumping semconv package.. This one would require more approvals from the Go SIG. |
Sounds good. |
Required because of open-telemetry/opentelemetry-go#4754 (part of https://github.com/open-telemetry/opentelemetry-go/releases/tag/v1.22.0).
CC @open-telemetry/go-approvers