Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracking branch for a large bundle of updates. #104

Merged
merged 27 commits into from
May 29, 2024
Merged

Tracking branch for a large bundle of updates. #104

merged 27 commits into from
May 29, 2024

Conversation

Westbrook
Copy link
Contributor

@Westbrook Westbrook commented May 26, 2024

After running the CLI, I found that a number of the dependencies were out of date, or used deprecated configs, etc. I manually updated a generated project and have been back porting the required change to the CLI piece by piece.

What I did

  1. Made a bunch of stand alone updates in individual PRs to this branch then overtime will hopefully catch the whole generator up to "modern" 😜 dependencies and practices.

I'd love to include an update to eslint@9.x but https://github.com/import-js/eslint-plugin-import doesn't seem ready to make the update... so, I guess skipping for now is OK.

CI doesn't test the CLI in a bullet proof way, but I'll be doing some more manual testing after all of the individual PRs have merged.

fixes #89
fixes #87
fixes #79
fixes #46

@Westbrook
Copy link
Contributor Author

This now works as expected for projects generated with:

  • Scaffold
  • App
  • lint, test, demo, build
  • ts, yes
  • write to disc
  • npm

I'm gonna step through some of the other options over the next day or two, but this may be ready to go to master as is, in that many things don't work there anyways and a full overview of all of the things is difficult to achieve by a single tester.

Also, renovate running free into master makes maintaining a long living branch (even just a few days) a bit of a pita.

@Westbrook Westbrook merged commit 372448e into master May 29, 2024
4 checks passed
@Westbrook Westbrook deleted the updates branch May 29, 2024 13:03
@peschee
Copy link

peschee commented May 29, 2024

🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants