Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update dependencies #38

Closed

Conversation

jorenbroekema
Copy link
Contributor

Updated some of the deps in one go instead of multiple renovate bot PRs.

One thing I could not update is Husky.
Husky now requires the hooks to be in .sh files which need execution permissions. Currently, create does not take into account permissions, so if you give it +x in the templates, and run the generator, those execute permissions are lost, meaning husky won't work for the end user.

I couldn't find a straight-forward way to read out the octal permission code of a file. What NodeJS does let you do is check if it can execute, you could store that, but then it's kinda hard to add this permission upon writing file on disk, because fs.chmod only lets you pass full octal permission code, not something like +x 😭 kinda sad that the Node fs module is pretty bad at permissions, compared to how easy it is with linux commands. So yeah, I left it out of this PR for now...

@jorenbroekema
Copy link
Contributor Author

Just found https://www.npmjs.com/package/fs-chmod, might try that

@Westbrook
Copy link
Contributor

Included in #104

@Westbrook Westbrook closed this May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants