Change description to desc in tob-2023 #460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calumbell
approved these changes
Jul 29, 2024
There was a problem hiding this comment.
Thanks for getting this fixed! It has been an annoyance working on the front-end site with the property names desc and description not matching.
The PR runs as expected on local. Checked perhaps twenty or so monsters with different combinations of action types. All looks good!
I'll go ahead and approve and merge to staging. Thanks again for your work!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tob-2023 is the only document (as far as I have encountered) that uses "description" instead of "desc". This is inconsistent and will trip up API consumers.