Fixes to a5e np cs and tob1 2023 errors #479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Blackguard still had its description in the stat block.
calumbell
approved these changes
Jul 30, 2024
There was a problem hiding this comment.
Hi, thanks for your contribution!
These changes look good to me! Everything runs as expected on local. Ran some tests by spinning up the F.E. site on local, pointing it at the Django test server, and visiting some of the pages changed by this PR:
- /monsters/queenofnightandmagic-tob1-2023
- /monsters/haugbui-tob1-2023
- /monsters/blackguard-a5e
- /monsters/adult-emerald-dragon-a5e
- /monsters/goblin-shieldbearer-a5e
- /monsters/green-hag-a5e
- /monsters/guard-squad-a5e
- /monsters/treant-a5e
- /monsters/will-o-wisp-a5e
These monster pages look a lot better with restructured JSON input, nice work!
Ran into a merge conflict due to PR #460 also changing data/v1/tob-2023/Monster.json, but it was a simple enough fix (changing the description key back to desc in the entries changed).
I'll go ahead and get this PR approved. Thanks again for your help!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bunch of NPCs in the A5e Menagerie had parts of their descriptions in their stat block. I also confirmed that, even though sometimes a stat block refers to another monster, that's because its a variant. Like pirate captain and bandit captian, spy and cutthroat, master spy and assassin and others. That's actually intended.