Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Weapons json data #9

Merged
merged 5 commits into from
Jul 17, 2019
Merged

Add Weapons json data #9

merged 5 commits into from
Jul 17, 2019

Conversation

gbalbuena
Copy link
Contributor

No description provided.

@augustjohnson
Copy link
Collaborator

augustjohnson commented Jul 17, 2019 via email

@gbalbuena
Copy link
Contributor Author

I need the data, this is actually a json version of a yaml in my personal project, please be free to use it or change at will.

Don't have time to learn django, but a pr fresh with the code will give me an idea for future contributions

@eepMoody
Copy link
Collaborator

eepMoody commented Jul 17, 2019

Yeah this is super handy! I think before we build an endpoint off it I may want to try and remap a few things to be more consistent with our existing data but the data itself is an awesome starting point.

eg. attacks from monsters have 'damage_dice', while these have the damage & type together. But this is all so well-structured already that should be super simple and something I can bust through this weekend with a regex or something.

@eepMoody eepMoody merged commit 97f59a8 into open5e:master Jul 17, 2019
eepMoody added a commit that referenced this pull request Nov 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants