Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Rails 5.0 #1130

Closed
wants to merge 4 commits into from
Closed

Conversation

shlok007
Copy link
Member

@shlok007 shlok007 commented Aug 9, 2016

Refer to issue #1087

2596c50 This commit updates the Gemfile with compatible version of gems for Rails 5.0

519a361 Committed after running rails app:update . The overwritten configurations had to be added manually so, kindly review this.
Approach taken from: http://pages.citebite.com/q5b3s6r9u4nyk

cdd2242 Generated new schema.
Reference: https://hashrocket.com/blog/posts/how-to-upgrade-to-rails-5#4-generate-the-db-schema-rb-file-again

Note: This is an ongoing PR and contains incomplete changes.

@hennevogel
Copy link
Member

If it's ongoing please open the PR once you're ready for us to pull :-)

@hennevogel
Copy link
Member

Especially after your PR to rails_observers is merged because this won't go into OSEM before...

@ChrisBr
Copy link
Member

ChrisBr commented Aug 17, 2016

So let's close this one till it is ready to merge?

Anyway, @shlok007 thanks for your contribution and I will look forward when it's ready to merge! Highly appreciated 👍

@ChrisBr ChrisBr closed this Aug 17, 2016
@siaw23-retired
Copy link
Contributor

any update on this? @ChrisBr @hennevogel @shlok007

@AEtherC0r3 AEtherC0r3 mentioned this pull request Jan 5, 2018
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants