Asset compression #1923
Merged
Asset compression #1923
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
config/application.rb
Outdated
| @@ -60,6 +60,13 @@ class Application < Rails::Application | |||
| # Version of your assets, change this if you want to expire all your assets | |||
| config.assets.version = '1.0' | |||
|
|
|||
| # Set cache headers | |||
| config.static_cache_control = "public, max-age=31536000" | |||
There was a problem hiding this comment.
http://edgeguides.rubyonrails.org/5_0_release_notes.html#railties-deprecations
Shall we re-write as following?
config.public_file_server.headers = { 'Cache-Control' => 'public, max-age=31536000' }
bear454
force-pushed
the
asset-compression
branch
from
8840e9a
to
712bca5
Compare
AEtherC0r3
suggested changes
Jan 5, 2018
config/application.rb
Outdated
|
|
||
| # Errors raised within `after_rollback`/`after_commit` propagate normally | ||
| # like in other Active Record callbacks. | ||
| config.active_record.raise_in_transactional_callbacks = true |
There was a problem hiding this comment.
This is deprecated in Rails 5. I had removed this line in #1130, so I'm guessing it was re-added because of a conflict during a rebase
There was a problem hiding this comment.
There was a problem hiding this comment.
That's applicable to Rails 4.2. In Rails 5.0 those exceptions are not suppressed and that line only shows a depreciation warning rails/rails@07d3d40
bear454
force-pushed
the
asset-compression
branch
from
712bca5
to
1dd2de5
Compare
|
@AEtherC0r3 ... are we good? |
AEtherC0r3
approved these changes
Jan 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
masterbranch.Short description of what this resolves/which issues does this fix?:
Changes proposed in this pull request: