Success page update (#113)

- [x] Updated the "How to contribute" link (#108) - [x] Moved Feedback to app header (#104) - [x] Updated the "Search for device" icon
openandroidinstaller-dev · Mar 24, 2023 · 306c789 · 306c789
2 parents b17020a + f24ed79
commit 306c789
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 6 deletions.
diff --git a/openandroidinstaller/openandroidinstaller.py b/openandroidinstaller/openandroidinstaller.py
@@ -97,7 +97,10 @@ def __init__(self, state: AppState):
         )
 
         # create the install view
-        self.install_view = InstallView(on_confirm=self.to_next_view, state=self.state)
+        self.install_view = InstallView(
+            on_confirm=self.to_next_view,
+            state=self.state,
+        )
 
         # create the final success view
         self.final_view = SuccessView(state=self.state)
@@ -247,6 +250,17 @@ def main(page: Page, test: bool = False, test_config: str = "sargo"):
                 padding=15,
                 tooltip="Frequently asked questions and encountered issues.",
             ),
+            Container(
+                content=ElevatedButton(
+                    icon=icons.FEEDBACK_OUTLINED,
+                    text="Give feedback",
+                    on_click=lambda _: webbrowser.open(
+                        "https://openandroidinstaller.org/feedback.html"
+                    ),
+                ),
+                padding=15,
+                tooltip="Give feedback about your experience with OpenAndroidInstaller",
+            ),
             Container(
                 content=ElevatedButton(
                     icon=icons.BUG_REPORT_OUTLINED,

diff --git a/openandroidinstaller/views/start_view.py b/openandroidinstaller/views/start_view.py
@@ -186,7 +186,7 @@ def build(self):
                         FilledButton(
                             "Search for device",
                             on_click=self.search_devices,
-                            icon=icons.PHONE_ANDROID,
+                            icon=icons.DEVICES_OTHER_OUTLINED,
                             expand=True,
                             tooltip="Search for a connected device.",
                         ),

diff --git a/openandroidinstaller/views/success_view.py b/openandroidinstaller/views/success_view.py
@@ -36,9 +36,6 @@ def build(
     ):
         def close_window(e):
             logger.success("Success! Close the window.")
-            # open the feedback page
-            feedback_url = "https://openandroidinstaller.org/feedback.html"
-            webbrowser.open(feedback_url)
             # close the window
             self.page.window_close()
 
@@ -47,7 +44,7 @@ def close_window(e):
             get_title("Installation completed successfully!"),
         ]
         # right view main part
-        contribute_link = "https://github.com/openandroidinstaller-dev/openandroidinstaller#contributing"
+        contribute_link = "https://openandroidinstaller.org/#contribute"
         self.right_view.controls = [
             Text(
                 "Now your devices boots into the new OS. Have fun with it!",