Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Success page update #113

Merged
merged 10 commits into from
Mar 24, 2023
Merged

Success page update #113

merged 10 commits into from
Mar 24, 2023

Conversation

MagicLike
Copy link
Member

@MagicLike MagicLike commented Mar 12, 2023 •
edited
Loading

tsterbak and others added 3 commits March 6, 2023 09:24
@tsterbak
Release 0.4.1-beta (openandroidinstaller-dev#96)
80a563f 
This Release adds

Support for:
- Samsung Galaxy S10e (beyond0lte)
- Samsung Galaxy S10+ (beyond2lte)
- Samsung Galaxy Note 10+ (d2s)
- Samsung Galaxy Note 8 (greatlte) thanks to @freechelmi 

Features:
- new image for samsung bixby button
- now wait for recovery and sideload to become available 

Fixes:
- Fix issue with whitespaces in paths (openandroidinstaller-dev#95)
- Add proper instructions to unlock the bootloader for recent Samsung
devices.
- Make text in advanced output easier to copy
@MagicLike
Updated contribute_link
e3c12e6
@MagicLike
Moved feedback to app header
1a99a42 
Moved feedback to app header instead of opening it automatically.
@MagicLike MagicLike changed the base branch from dev to main March 12, 2023 17:49
@tsterbak tsterbak self-requested a review March 12, 2023 18:09
@tsterbak tsterbak added the enhancement New feature or request label Mar 12, 2023
@tsterbak tsterbak added this to the Release Beta 0.4.2 milestone Mar 12, 2023
@MagicLike MagicLike changed the base branch from main to dev March 12, 2023 19:53
@MagicLike
Copy link
Member Author

Commit 13c3500 contains bugs, please check - see #101 (comment)

@MagicLike
Put restart and finish buttons next to each other
4222309
@MagicLike
Updated search icon
2d7b0e2 
Updated the search icon, due to coming support for other devices than phones.
@tsterbak
Copy link
Member

Hey, since the restart button will be a bit larger operation and I prefer to merge the other changes from this branch rather sooner than later, could you move the code related to the restart button to another branch and open a separate PR for it?

I want to get the oneplus stuff and fixes out in a new release as soon as possible and would include everthying from this branch other than the stuff with the restart button. (I plan to have a release ready until Monday or Tuesday, let's see)

@MagicLike
Copy link
Member Author

Hey, since the restart button will be a bit larger operation and I prefer to merge the other changes from this branch rather sooner than later, could you move the code related to the restart button to another branch and open a separate PR for it?

I want to get the oneplus stuff and fixes out in a new release as soon as possible and would include everthying from this branch other than the stuff with the restart button. (I plan to have a release ready until Monday or Tuesday, let's see)

👍 Done, I just reverted the two commits regarding the restart button - I will open a new PR if this one here gets merged!

@MagicLike MagicLike marked this pull request as ready for review March 23, 2023 18:49
@tsterbak
Copy link
Member

👍 Done, I just reverted the two commits regarding the restart button - I will open a new PR if this one here gets merged!

Great, thank you! I'll try to get everything merged as soon as possible :)

@tsterbak tsterbak changed the base branch from dev to release-0.4.2-beta March 24, 2023 17:10
@tsterbak tsterbak merged commit 306c789 into openandroidinstaller-dev:release-0.4.2-beta Mar 24, 2023
@MagicLike MagicLike mentioned this pull request Mar 24, 2023
Merged
@MagicLike MagicLike deleted the success-page branch March 27, 2023 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsterbak tsterbak tsterbak approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
Release Beta 0.4.2
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@MagicLike @tsterbak