Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Success page update #113

Merged
16 changes: 15 additions & 1 deletion openandroidinstaller/openandroidinstaller.py
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,10 @@ def __init__(self, state: AppState):
)

# create the install view
self.install_view = InstallView(on_confirm=self.to_next_view, state=self.state)
self.install_view = InstallView(
on_confirm=self.to_next_view,
state=self.state,
)

# create the final success view
self.final_view = SuccessView(state=self.state)
Expand Down Expand Up @@ -247,6 +250,17 @@ def main(page: Page, test: bool = False, test_config: str = "sargo"):
padding=15,
tooltip="Frequently asked questions and encountered issues.",
),
Container(
content=ElevatedButton(
icon=icons.FEEDBACK_OUTLINED,
text="Give feedback",
on_click=lambda _: webbrowser.open(
"https://openandroidinstaller.org/feedback.html"
),
),
padding=15,
tooltip="Give feedback about your experience with OpenAndroidInstaller",
),
Container(
content=ElevatedButton(
icon=icons.BUG_REPORT_OUTLINED,
Expand Down
2 changes: 1 addition & 1 deletion openandroidinstaller/views/start_view.py
Original file line number Diff line number Diff line change
Expand Up @@ -186,7 +186,7 @@ def build(self):
FilledButton(
"Search for device",
on_click=self.search_devices,
icon=icons.PHONE_ANDROID,
icon=icons.DEVICES_OTHER_OUTLINED,
expand=True,
tooltip="Search for a connected device.",
),
Expand Down
5 changes: 1 addition & 4 deletions openandroidinstaller/views/success_view.py
Original file line number Diff line number Diff line change
Expand Up @@ -36,9 +36,6 @@ def build(
):
def close_window(e):
logger.success("Success! Close the window.")
# open the feedback page
feedback_url = "https://openandroidinstaller.org/feedback.html"
webbrowser.open(feedback_url)
# close the window
self.page.window_close()

Expand All @@ -47,7 +44,7 @@ def close_window(e):
get_title("Installation completed successfully!"),
]
# right view main part
contribute_link = "https://github.com/openandroidinstaller-dev/openandroidinstaller#contributing"
contribute_link = "https://openandroidinstaller.org/#contribute"
self.right_view.controls = [
Text(
"Now your devices boots into the new OS. Have fun with it!",