CADC-8776 update doi service int-test #9
Conversation
jburke-cadc
commented
Nov 26, 2024
jburke-cadc
commented
- int-tests no longer use the doiadmin user to run tests, the developer can use either a local VOSpace service they own or their home folder in a production VOSpace service.
- individual CRUD int-tests replaced with a single DOI lifecycle int-test
- intTest.properties file to set the doi service for testing and the VOSURI for the parent DOI folder in VOSpace.
| @@ -0,0 +1,7 @@ | |||
| # intTest.properties expects the following entries: | |||
|
|
|||
There was a problem hiding this comment.
Shouldn't this file be in src/intTest directory instead?
| The `doi-auth.pem` user is a member of this group, giving this user read/write access to a test DOI. | ||
| The `doi-noauth.pem` user is not a member of this group, giving this user read-only access to a test DOI. | ||
| - `doi-admin.pem` owns and has full permissions to a test DOI. | ||
| - `doi-auth.pem` has read-write permissions to a test DOI. |
There was a problem hiding this comment.
How? A group is required for that I assume.
| DOI_PARENT_PATH = vosURI.getPath(); | ||
| } | ||
|
|
||
| // s = props.getProperty("metadataFilePrefix"); |
| log.info("failed to load/read config", e); | ||
| } | ||
|
|
||
| } |
There was a problem hiding this comment.
Isn't this supposed to fail on ok=false?
| throw new IllegalStateException(String.format("node %s must have inheritPermissions set to true", path)); | ||
| } | ||
| // check inheritPermissions is true (does inheritPermissions need to be true?) | ||
| if (!containerNode.inheritPermissions) { |
There was a problem hiding this comment.
It depends how this system expects it to behave. If it's not, then the system needs to explicitly set the permissions for each node when it gets created. Otherwise, you only set it once in the root directory and the permissions are inherited.
| @@ -237,7 +237,7 @@ private List<Node> getOwnedDOIList() throws Exception { | |||
| ContainerNode doiRootNode = vospaceDoiClient.getContainerNode(""); | |||
| if (doiRootNode != null) { | |||
| for (Node childNode : doiRootNode.getNodes()) { | |||
| // TODO: configure doiadmin viewing of all nodes | |||
| // TODO: configure doi admin viewing of all nodes | |||
There was a problem hiding this comment.
I think that's available regardless of the permissions down below.
| # (optional) Group URI for a group that has read/write permissions to test DOI's | ||
| ca.nrc.cadc.doi.test.groupUri = {group URI} | ||
| # (optional) Create a random DOI ID for testing | ||
| ca.nrc.cadc.doi.randomTestID = {true|false} |
There was a problem hiding this comment.
Is this really necessary? Can just the prefix and different test directory be enough? Under what circumstances would int testing interfere with production and what would be the consequences?
If you can get rid of this then you can remove traces of test code in the service code as well.
| String nextDoiSuffix; | ||
| if (randomName) { | ||
| if (randomTestID) { |
There was a problem hiding this comment.
This could be remove if random test id not necessary.
